Panagiotis Papadopoulos
dcfdb67539
refactor(backend_log): improve handle 'file not found'
...
handle errors more "user friendly" and actually
let the user know, that either the file is not
existing (yet), or that reading the log failed.
2025-01-13 09:21:24 +01:00
Panagiotis Papadopoulos
67d858441a
refactor(backend_log): include filename in log
2025-01-13 09:21:24 +01:00
Panagiotis Papadopoulos
c4ad84ab06
refactor(backend_log): print error to the log
2025-01-13 09:21:24 +01:00
Panagiotis Papadopoulos
eb4b5a44df
refactor(backend_log): use path.join for log file path
2025-01-13 09:21:24 +01:00
Panagiotis Papadopoulos
06ebcc210e
refactor(backend_log): use async readFile
...
using synchronous functions on the backend
is not recommended, as it is "blocking the event loop", i.e. no other tasks get executed/processed,
while the file is being read
2025-01-13 09:21:24 +01:00
Panagiotis Papadopoulos
5373ef509b
chore(prettier): fix code style
2025-01-13 08:28:12 +01:00
Panagiotis Papadopoulos
6818b2d54c
style: move "important" funcs to top of file
2025-01-13 08:26:07 +01:00
Panagiotis Papadopoulos
c47522eb50
refactor(data_dir): pass DIR_NAME as argument to getTriliumDir
...
makes it a bit cleaner and easier to test in the future,
as it is one thing less that'd need mocking :-)
2025-01-13 08:26:07 +01:00
Panagiotis Papadopoulos
94b8bcf8c9
refactor(data_dir): export functions to allow for testing
2025-01-13 08:26:07 +01:00
Panagiotis Papadopoulos
8b1071c459
refactor(data_dir): export dirs as frozen readonly object
...
previously exported object allowed the values to be changed
accidentally at runtime and buildtime
2025-01-13 08:26:07 +01:00
Panagiotis Papadopoulos
759d24855b
style(data_dir): fix indentation
2025-01-13 08:26:07 +01:00
Panagiotis Papadopoulos
7a1e8714af
refactor(data_dir): logically order/split cases in getTriliumDataDir
...
- the blocks now clearly follow the intended logic described in the comments
- I renamed the `getAppDataDir` to more specific `getPlatformAppDataDir`
2025-01-13 08:25:53 +01:00
Panagiotis Papadopoulos
3481c8ba84
refactor(data_dir): use path.join for safer joins
...
https://nodejs.org/api/path.html#pathjoinpaths
2025-01-13 08:24:04 +01:00
Panagiotis Papadopoulos
8826021c63
refactor(data_dir): add createDirIfNotExisting function
...
removes some code duplication
2025-01-13 08:24:04 +01:00
Panagiotis Papadopoulos
61a19d5628
refactor(data_dir): add FOLDER_PERMISSION const
...
gets rid of previously "magic number"
2025-01-13 08:24:01 +01:00
Adorian Doran
c9bf752b1f
Merge branch 'develop' of https://github.com/TriliumNext/Notes into style/next/forms
2025-01-12 23:45:03 +02:00
Panagiotis Papadopoulos
ea621ef8e1
chore(prettier): fix code style
2025-01-12 13:30:02 +01:00
Panagiotis Papadopoulos
d1bd2d2812
refactor(routes/login): remove unused rendering of HTML
2025-01-12 13:13:59 +01:00
Panagiotis Papadopoulos
59ecc614c2
refactor: call logout route via JS
...
required for csrf-csrf to correctly protect against
CSRF, as it required the _csrf cookie AND the
x-csrf-token HTTP header, the latter cannot be set
via simple Form POST action
using "../login" here, because "server" method is automatically prepending all paths with "/api",
which we don't want here, as we want "/login"
2025-01-12 11:43:41 +01:00
Panagiotis Papadopoulos
c36085e580
chore: fix TS warning by type narrowing
...
`req.csrfToken` might be undefined according to `csrf-csrf`
provided types, so use type narrowing to make sure it exists,
before calling it
2025-01-12 10:22:05 +01:00
Panagiotis Papadopoulos
d20a3bab2a
fix(csrfMiddleware): use sessionSecret instead
...
since `cookie-parser` is not configured with a secret,
req.secret is not set and hence is `undefined`,
which then is used as literal 'undefined' in the hashing function – making it less secure.
Instead we can use the existing sessionSecret:
the `csrf-csrf` developer confirmed in their Discord chat,
that it would be ok to use the same secret here.
2025-01-12 10:22:05 +01:00
Panagiotis Papadopoulos
b787610717
refactor: replace csurf with csrf-csrf
...
I've kept the identical same settings as before –
however they are not *ideal* from what I read.
More secure settings will need to be tested a bit more thoroughly first and will be a separate PR.
2025-01-12 10:22:05 +01:00
Elian Doran
9db9d412d9
feat(import/markdown): preserve language tags when possible
2025-01-11 15:22:36 +02:00
Elian Doran
0e67078256
feat(export/md): rewrite JavaScript code block languages
2025-01-11 14:11:18 +02:00
Elian Doran
703a70056b
feat(code_notes): reintroduce ESLint for server notes
2025-01-11 12:18:16 +02:00
Elian Doran
05529b84ab
chore(client/ts): port options
2025-01-11 11:45:06 +02:00
Elian Doran
7e61af1cc3
chore(client/ts): port options/text_notes
2025-01-11 11:21:14 +02:00
Elian Doran
677760282c
chore(client/ts): port options/other
2025-01-11 11:18:50 +02:00
Elian Doran
03241a8967
chore(client/ts): port options/images
2025-01-11 11:13:11 +02:00
Elian Doran
6665a8d97f
chore(client/ts): port options/codeNotes
2025-01-11 11:11:57 +02:00
Elian Doran
552cc2753f
chore(client/ts): port options/appearance
2025-01-11 11:02:22 +02:00
Elian Doran
5bfcf88acd
chore(client/ts): port options/advanced
2025-01-11 10:51:35 +02:00
Elian Doran
fcb7d9754f
Merge pull request #908 from pano9000/fix_printthis_#901
...
fix(styles): fix ck-editor checkboxes not showing checkmark while printing
2025-01-11 01:51:51 +02:00
Elian Doran
c94346c6b9
chore(client/ts): port widgets/buttons/launcher
2025-01-11 01:46:04 +02:00
Elian Doran
7e00b889a0
chore(client/ts): port api_log
2025-01-11 01:46:04 +02:00
Elian Doran
e2628c58c5
chore(test): move spec to source dir
2025-01-10 22:04:04 +02:00
Elian Doran
36387deb0d
chore(test): add test for markdown import
2025-01-10 22:03:08 +02:00
Elian Doran
a05e174640
chore(test): add test for content_renderer#renderCode
2025-01-10 21:49:33 +02:00
Elian Doran
f026706e25
chore(test): fix typing errors in parser
2025-01-10 21:21:32 +02:00
Elian Doran
180af2ce30
fix(search): limit from UI not applied ( closes #920 )
2025-01-10 20:10:41 +02:00
Elian Doran
7ea324bc5b
chore(test): fix circular reference in backend tests
2025-01-10 20:09:49 +02:00
Elian Doran
902c6f87a8
style(next): fix MIca on horizontal layout
2025-01-10 18:44:13 +02:00
Panagiotis Papadopoulos
01515bd580
fix(styles): fix ck-editor checkboxes not showing checkmark while printing
...
Due to CSS specificity using plain "input[checked]::before" does not
work.
fixes #901
2025-01-10 08:22:36 +01:00
Elian Doran
5111f1760d
chore(client/ts): port tab_row
2025-01-09 20:20:06 +02:00
Elian Doran
2080ce5123
refactor(libs): use webpack instead of hard-coded dependency
2025-01-09 19:23:47 +02:00
Elian Doran
324696bc54
refactor(ts): enable verbatim module syntax
2025-01-09 18:36:24 +02:00
Elian Doran
4cbb529fd4
chore(prettier): fix all files
2025-01-09 18:07:02 +02:00
Adorian Doran
0115ea8088
style(next): create a CSS file for form-related styles
2025-01-09 01:23:17 +02:00
Elian Doran
6cedd0381d
Merge pull request #903 from TriliumNext/style/next/restyle-help-dialog-
...
Style Next: Restyle the help dialog
2025-01-09 00:38:16 +02:00
Adorian Doran
e8fe290d89
style(next): tweak color
2025-01-09 00:15:59 +02:00
