From fcd87b3e2d7dd01802b2b2f2dba7f400cfbfb56c Mon Sep 17 00:00:00 2001
From: zadam <zadam.apps@gmail.com>
Date: Tue, 6 Aug 2019 21:36:54 +0200
Subject: [PATCH] instantiate widgets dynamically

---
 src/public/javascripts/services/sidebar.js | 44 ++++------------------
 src/public/stylesheets/style.css           |  1 +
 2 files changed, 8 insertions(+), 37 deletions(-)

diff --git a/src/public/javascripts/services/sidebar.js b/src/public/javascripts/services/sidebar.js
index 1a47d14e6..115870d9c 100644
--- a/src/public/javascripts/services/sidebar.js
+++ b/src/public/javascripts/services/sidebar.js
@@ -48,46 +48,16 @@ class Sidebar {
     async noteLoaded() {
         this.$widgets.empty();
 
-        this.addAttributesWidget();
-        this.addNoteInfoWidget();
-        this.addLinkMapWidget();
-        this.addNoteRevisionsWidget();
-    }
+        const widgetClasses = [AttributesWidget, LinkMapWidget, NoteRevisionsWidget, NoteInfoWidget];
 
-    async addAttributesWidget() {
-        const $widget = this.createWidgetElement();
+        for (const widgetClass of widgetClasses) {
+            const $widget = this.createWidgetElement();
 
-        const attributesWidget = new AttributesWidget(this.ctx, $widget);
-        await attributesWidget.renderBody();
+            const attributesWidget = new widgetClass(this.ctx, $widget);
+            attributesWidget.renderBody(); // let it run in parallel
 
-        this.$widgets.append($widget);
-    }
-
-    async addNoteInfoWidget() {
-        const $widget = this.createWidgetElement();
-
-        const noteInfoWidget = new NoteInfoWidget(this.ctx, $widget);
-        await noteInfoWidget.renderBody();
-
-        this.$widgets.append($widget);
-    }
-
-    async addLinkMapWidget() {
-        const $widget = this.createWidgetElement();
-
-        const linkMapWidget = new LinkMapWidget(this.ctx, $widget);
-        await linkMapWidget.renderBody();
-
-        this.$widgets.append($widget);
-    }
-
-    async addNoteRevisionsWidget() {
-        const $widget = this.createWidgetElement();
-
-        const noteRevisionsWidget = new NoteRevisionsWidget(this.ctx, $widget);
-        await noteRevisionsWidget.renderBody();
-
-        this.$widgets.append($widget);
+            this.$widgets.append($widget);
+        }
     }
 
     createWidgetElement() {
diff --git a/src/public/stylesheets/style.css b/src/public/stylesheets/style.css
index fc715f401..25131dd06 100644
--- a/src/public/stylesheets/style.css
+++ b/src/public/stylesheets/style.css
@@ -118,6 +118,7 @@ ul.fancytree-container {
 
 .note-detail-sidebar {
     min-width: 350px;
+    max-width: 350px;
     overflow: auto;
     padding-top: 12px;
     padding-left: 7px;