mirror of
				https://github.com/TriliumNext/Notes.git
				synced 2025-10-31 21:11:30 +08:00 
			
		
		
		
	chore(docker): remove TODO
This commit is contained in:
		
							parent
							
								
									75431ca634
								
							
						
					
					
						commit
						e9fa37c4ee
					
				| @ -18,7 +18,6 @@ RUN npm ci && \ | |||||||
|       /usr/src/app/build \ |       /usr/src/app/build \ | ||||||
|       /tmp/node-compile-cache |       /tmp/node-compile-cache | ||||||
| 
 | 
 | ||||||
| #TODO: run cleanupNodeModules script |  | ||||||
| #TODO: improve node_modules handling in copy-dist/Dockerfile -> remove duplicated work | #TODO: improve node_modules handling in copy-dist/Dockerfile -> remove duplicated work | ||||||
| #      currently copy-dist will copy certain node_module folders, but in the Dockerfile we delete them again (to keep image size down), | #      currently copy-dist will copy certain node_module folders, but in the Dockerfile we delete them again (to keep image size down), | ||||||
| #      as we install necessary dependencies in runtime buildstage anyways | #      as we install necessary dependencies in runtime buildstage anyways | ||||||
|  | |||||||
| @ -18,7 +18,6 @@ RUN npm ci && \ | |||||||
|       /usr/src/app/build \ |       /usr/src/app/build \ | ||||||
|       /tmp/node-compile-cache |       /tmp/node-compile-cache | ||||||
| 
 | 
 | ||||||
| #TODO: run cleanupNodeModules script |  | ||||||
| #TODO: improve node_modules handling in copy-dist/Dockerfile -> remove duplicated work | #TODO: improve node_modules handling in copy-dist/Dockerfile -> remove duplicated work | ||||||
| #      currently copy-dist will copy certain node_module folders, but in the Dockerfile we delete them again (to keep image size down), | #      currently copy-dist will copy certain node_module folders, but in the Dockerfile we delete them again (to keep image size down), | ||||||
| #      as we install necessary dependencies in runtime buildstage anyways | #      as we install necessary dependencies in runtime buildstage anyways | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Panagiotis Papadopoulos
						Panagiotis Papadopoulos