From dd7df1344e1c7699b289accfc53e7202de31f424 Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Sat, 10 May 2025 15:18:57 +0300 Subject: [PATCH] fix(ckeditor5): build failing due to types path --- .../Project Structure/CKEditor/Plugin migration guide.md | 1 + packages/ckeditor5-admonition/tsconfig.dist.json | 2 +- packages/ckeditor5-footnotes/tsconfig.dist.json | 2 +- packages/ckeditor5-keyboard-marker/tsconfig.dist.json | 2 +- packages/ckeditor5-math/tsconfig.dist.json | 2 +- packages/ckeditor5-mermaid/tsconfig.dist.json | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/Developer Guide/Developer Guide/Project Structure/CKEditor/Plugin migration guide.md b/docs/Developer Guide/Developer Guide/Project Structure/CKEditor/Plugin migration guide.md index e92e4d181..8b87f2721 100644 --- a/docs/Developer Guide/Developer Guide/Project Structure/CKEditor/Plugin migration guide.md +++ b/docs/Developer Guide/Developer Guide/Project Structure/CKEditor/Plugin migration guide.md @@ -35,6 +35,7 @@ In the newly copied package, go to `package.json` and edit: 3. Similarly, update `vitest` dependencies to match the monorepo one. 4. Remove the `prepare` entry from the `scripts` section. 5. Change `build:dist` to simply `build` in order to integrate it with NX. +6. In `tsconfig.dist.json`, change `typings/types` to `../typings/types.d.ts` to be compatible with the latest TypeScript version. ## Step 4. Install missing dependencies and build errors diff --git a/packages/ckeditor5-admonition/tsconfig.dist.json b/packages/ckeditor5-admonition/tsconfig.dist.json index 80a1eba4a..3749a505c 100644 --- a/packages/ckeditor5-admonition/tsconfig.dist.json +++ b/packages/ckeditor5-admonition/tsconfig.dist.json @@ -6,7 +6,7 @@ "rootDir": "./src", "composite": false, "types": [ - "./typings/types" + "../typings/types.d.ts" ] } } diff --git a/packages/ckeditor5-footnotes/tsconfig.dist.json b/packages/ckeditor5-footnotes/tsconfig.dist.json index 80a1eba4a..3749a505c 100644 --- a/packages/ckeditor5-footnotes/tsconfig.dist.json +++ b/packages/ckeditor5-footnotes/tsconfig.dist.json @@ -6,7 +6,7 @@ "rootDir": "./src", "composite": false, "types": [ - "./typings/types" + "../typings/types.d.ts" ] } } diff --git a/packages/ckeditor5-keyboard-marker/tsconfig.dist.json b/packages/ckeditor5-keyboard-marker/tsconfig.dist.json index 80a1eba4a..3749a505c 100644 --- a/packages/ckeditor5-keyboard-marker/tsconfig.dist.json +++ b/packages/ckeditor5-keyboard-marker/tsconfig.dist.json @@ -6,7 +6,7 @@ "rootDir": "./src", "composite": false, "types": [ - "./typings/types" + "../typings/types.d.ts" ] } } diff --git a/packages/ckeditor5-math/tsconfig.dist.json b/packages/ckeditor5-math/tsconfig.dist.json index 80a1eba4a..3749a505c 100644 --- a/packages/ckeditor5-math/tsconfig.dist.json +++ b/packages/ckeditor5-math/tsconfig.dist.json @@ -6,7 +6,7 @@ "rootDir": "./src", "composite": false, "types": [ - "./typings/types" + "../typings/types.d.ts" ] } } diff --git a/packages/ckeditor5-mermaid/tsconfig.dist.json b/packages/ckeditor5-mermaid/tsconfig.dist.json index 80a1eba4a..3749a505c 100644 --- a/packages/ckeditor5-mermaid/tsconfig.dist.json +++ b/packages/ckeditor5-mermaid/tsconfig.dist.json @@ -6,7 +6,7 @@ "rootDir": "./src", "composite": false, "types": [ - "./typings/types" + "../typings/types.d.ts" ] } }