From 57d945fff07a66b52975b4b98dacad6a4bbd781a Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Wed, 7 May 2025 10:03:29 +0300 Subject: [PATCH 1/2] feat(nx/ckeditor): set up cache --- packages/ckeditor5-admonition/package.json | 7 ++++++- packages/ckeditor5-footnotes/package.json | 7 ++++++- packages/ckeditor5-keyboard-marker/package.json | 7 ++++++- packages/ckeditor5-math/package.json | 7 ++++++- packages/ckeditor5-mermaid/package.json | 7 ++++++- 5 files changed, 30 insertions(+), 5 deletions(-) diff --git a/packages/ckeditor5-admonition/package.json b/packages/ckeditor5-admonition/package.json index 48996172a..1cb844834 100644 --- a/packages/ckeditor5-admonition/package.json +++ b/packages/ckeditor5-admonition/package.json @@ -86,6 +86,11 @@ } }, "nx": { - "name": "ckeditor5-admonition" + "name": "ckeditor5-admonition", + "targets": { + "build": { + "cache": "true" + } + } } } diff --git a/packages/ckeditor5-footnotes/package.json b/packages/ckeditor5-footnotes/package.json index 8bee7c2b9..b96bd25bd 100644 --- a/packages/ckeditor5-footnotes/package.json +++ b/packages/ckeditor5-footnotes/package.json @@ -85,6 +85,11 @@ } }, "nx": { - "name": "ckeditor5-footnotes" + "name": "ckeditor5-footnotes", + "targets": { + "build": { + "cache": "true" + } + } } } diff --git a/packages/ckeditor5-keyboard-marker/package.json b/packages/ckeditor5-keyboard-marker/package.json index 7d2f6100b..8666c019d 100644 --- a/packages/ckeditor5-keyboard-marker/package.json +++ b/packages/ckeditor5-keyboard-marker/package.json @@ -87,6 +87,11 @@ } }, "nx": { - "name": "ckeditor5-keyboard-marker" + "name": "ckeditor5-keyboard-marker", + "targets": { + "build": { + "cache": "true" + } + } } } diff --git a/packages/ckeditor5-math/package.json b/packages/ckeditor5-math/package.json index 4c8d87ca9..e11f64299 100644 --- a/packages/ckeditor5-math/package.json +++ b/packages/ckeditor5-math/package.json @@ -89,6 +89,11 @@ } }, "nx": { - "name": "ckeditor5-math" + "name": "ckeditor5-math", + "targets": { + "build": { + "cache": "true" + } + } } } diff --git a/packages/ckeditor5-mermaid/package.json b/packages/ckeditor5-mermaid/package.json index a95bf2b6a..a62271d59 100644 --- a/packages/ckeditor5-mermaid/package.json +++ b/packages/ckeditor5-mermaid/package.json @@ -91,6 +91,11 @@ "lodash-es": "^4.17.21" }, "nx": { - "name": "ckeditor5-mermaid" + "name": "ckeditor5-mermaid", + "targets": { + "build": { + "cache": "true" + } + } } } From b13bc23c24eb466609459a4cfda5218ff51d632b Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Wed, 7 May 2025 11:37:56 +0300 Subject: [PATCH 2/2] chore(nx/ckeditor): fix two @ts-expect-error --- packages/ckeditor5/src/plugins/cuttonote.ts | 3 +-- .../ckeditor5/src/plugins/file_upload/fileuploadediting.ts | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/ckeditor5/src/plugins/cuttonote.ts b/packages/ckeditor5/src/plugins/cuttonote.ts index 28fb0a98a..34c860d15 100644 --- a/packages/ckeditor5/src/plugins/cuttonote.ts +++ b/packages/ckeditor5/src/plugins/cuttonote.ts @@ -6,8 +6,7 @@ export default class CutToNotePlugin extends Plugin { private htmlDataProcessor!: HtmlDataProcessor; init() { - // @ts-ignore Not sure why we need to pass a document. - this.htmlDataProcessor = new HtmlDataProcessor(); + this.htmlDataProcessor = new HtmlDataProcessor(this.editor.editing.view.document); this.editor.ui.componentFactory.add( 'cutToNote', locale => { const view = new ButtonView( locale ); diff --git a/packages/ckeditor5/src/plugins/file_upload/fileuploadediting.ts b/packages/ckeditor5/src/plugins/file_upload/fileuploadediting.ts index e8ae16172..b44b11126 100644 --- a/packages/ckeditor5/src/plugins/file_upload/fileuploadediting.ts +++ b/packages/ckeditor5/src/plugins/file_upload/fileuploadediting.ts @@ -67,8 +67,7 @@ export default class FileUploadEditing extends Plugin { return; } - //@ts-expect-error Missing document. - const writer = new UpcastWriter(); + const writer = new UpcastWriter(this.editor.editing.view.document); for ( const fetchableFile of fetchableFiles ) { // Set attribute marking that the file was processed already.