Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-08-10 10:22:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(routes): refactor handleException and get rid of "any" type

Browse Source
This commit is contained in:
Panagiotis Papadopoulos 2025-03-07 22:27:13 +01:00
parent ba5152de40
commit d8ce385134
1 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/routes/routes.ts
View File

@ -493,22 +493,20 @@ function handleResponse(resultHandler: ApiResultHandler, req: express.Request, r
log.request(req, res, Date.now() - start, responseLength);
}
function handleException(e: any, method: HttpMethod, path: string, res: express.Response) {
log.error(`${method} ${path} threw exception: '${e.message}', stack: ${e.stack}`);
function handleException(e: unknown | Error, method: HttpMethod, path: string, res: express.Response) {
const [errMessage, errStack]: [message: string, stack: string] = (e instanceof Error)
? [e.message, e.stack || "No Stack Trace"]
: ["Unknown Error", "No Stack Trace"];
log.error(`${method} ${path} threw exception: '${errMessage}', stack: ${errStack}`);
const resStatusCode = (e instanceof ValidationError || e instanceof NotFoundError) ? e.statusCode : 500;
res.status(resStatusCode).json({
message: errMessage
});
if (e instanceof ValidationError) {
res.status(400).json({
message: e.message
});
} else if (e instanceof NotFoundError) {
res.status(404).json({
message: e.message
});
} else {
res.status(500).json({
message: e.message
});
}
}
function createUploadMiddleware() {