From d8b78d802512071bccbe17edb6ae4118dfd1d66d Mon Sep 17 00:00:00 2001
From: zadam <adam.zivner@gmail.com>
Date: Sun, 3 Feb 2019 16:27:26 +0100
Subject: [PATCH] check reference issues only for non deleted entities

---
 src/services/consistency_checks.js | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/services/consistency_checks.js b/src/services/consistency_checks.js
index d8eadd78c..63fa78919 100644
--- a/src/services/consistency_checks.js
+++ b/src/services/consistency_checks.js
@@ -92,38 +92,39 @@ async function findBrokenReferenceIssues() {
     await findIssues(`
           SELECT branchId, branches.noteId
           FROM branches LEFT JOIN notes USING(noteId)
-          WHERE notes.noteId IS NULL`,
+          WHERE branches.isDeleted = 0 AND notes.noteId IS NULL`,
         ({branchId, noteId}) => `Branch ${branchId} references missing note ${noteId}`);
 
     await findIssues(`
           SELECT branchId, branches.noteId AS parentNoteId
           FROM branches LEFT JOIN notes ON notes.noteId = branches.parentNoteId
-          WHERE branches.branchId != 'root' AND notes.noteId IS NULL`,
+          WHERE branches.isDeleted = 0 AND branches.branchId != 'root' AND notes.noteId IS NULL`,
         ({branchId, noteId}) => `Branch ${branchId} references missing parent note ${noteId}`);
 
     await findIssues(`
           SELECT attributeId, attributes.noteId
           FROM attributes LEFT JOIN notes USING(noteId)
-          WHERE notes.noteId IS NULL`,
+          WHERE attributes.isDeleted = 0 AND notes.noteId IS NULL`,
         ({attributeId, noteId}) => `Attribute ${attributeId} references missing source note ${noteId}`);
 
     // empty targetNoteId for relations is a special fixable case so not covered here
     await findIssues(`
           SELECT attributeId, attributes.value AS noteId
           FROM attributes LEFT JOIN notes ON notes.noteId = attributes.value
-          WHERE attributes.type = 'relation' AND attributes.value != '' AND notes.noteId IS NULL`,
+          WHERE attributes.isDeleted = 0 AND attributes.type = 'relation' 
+            AND attributes.value != '' AND notes.noteId IS NULL`,
         ({attributeId, noteId}) => `Relation ${attributeId} references missing note ${noteId}`);
 
     await findIssues(`
           SELECT linkId, links.noteId
           FROM links LEFT JOIN notes USING(noteId)
-          WHERE notes.noteId IS NULL`,
+          WHERE links.isDeleted = 0 AND notes.noteId IS NULL`,
         ({linkId, noteId}) => `Link ${linkId} references missing source note ${noteId}`);
 
     await findIssues(`
           SELECT linkId, links.noteId
           FROM links LEFT JOIN notes ON notes.noteId = links.targetNoteId
-          WHERE notes.noteId IS NULL`,
+          WHERE links.isDeleted = 0 AND notes.noteId IS NULL`,
         ({linkId, noteId}) => `Link ${linkId} references missing target note ${noteId}`);
 
     await findIssues(`