From d8224be62151ef306aeda8389d1f9332d1ec0ed4 Mon Sep 17 00:00:00 2001
From: Panagiotis Papadopoulos <pano_90@gmx.net>
Date: Sun, 22 Dec 2024 09:06:54 +0100
Subject: [PATCH] i18n: move kbd tag to translation string
 (search_definition.search_button)

here I've merged the two existing translations,
as it otherwise splits them up in an
awkward way for translations -
which also caused some mistranslations
already.
that way it also would've made it impossible to translate for RTL languages.
---
 src/public/app/widgets/ribbon_widgets/search_definition.js | 4 +---
 src/public/translations/cn/translation.json                | 3 +--
 src/public/translations/de/translation.json                | 3 +--
 src/public/translations/en/translation.json                | 3 +--
 src/public/translations/es/translation.json                | 3 +--
 src/public/translations/fr/translation.json                | 3 +--
 src/public/translations/ro/translation.json                | 3 +--
 src/public/translations/tw/translation.json                | 3 +--
 8 files changed, 8 insertions(+), 17 deletions(-)

diff --git a/src/public/app/widgets/ribbon_widgets/search_definition.js b/src/public/app/widgets/ribbon_widgets/search_definition.js
index 3b24d6988..106355e58 100644
--- a/src/public/app/widgets/ribbon_widgets/search_definition.js
+++ b/src/public/app/widgets/ribbon_widgets/search_definition.js
@@ -135,9 +135,7 @@ const TPL = `
                         <div style="display: flex; justify-content: space-evenly">
                             <button type="button" class="btn btn-sm search-button">
                                 <span class="bx bx-search"></span>
-                                ${t('search_definition.search')}
-                                
-                                <kbd>${t('search_definition.enter')}</kbd>
+                                ${t('search_definition.search_button')}
                             </button>
         
                             <button type="button" class="btn btn-sm search-and-execute-button">
diff --git a/src/public/translations/cn/translation.json b/src/public/translations/cn/translation.json
index d4c3de15a..65a9f5f94 100644
--- a/src/public/translations/cn/translation.json
+++ b/src/public/translations/cn/translation.json
@@ -816,8 +816,7 @@
     "debug": "调试",
     "debug_description": "调试将打印额外的调试信息到控制台，以帮助调试复杂查询",
     "action": "操作",
-    "search": "搜索",
-    "enter": "输入",
+    "search_button": "搜索 <kbd>回车</kbd>",
     "search_execute": "搜索并执行操作",
     "save_to_note": "保存到笔记",
     "search_parameters": "搜索参数",
diff --git a/src/public/translations/de/translation.json b/src/public/translations/de/translation.json
index a074a9085..3f5a7ffb6 100644
--- a/src/public/translations/de/translation.json
+++ b/src/public/translations/de/translation.json
@@ -811,8 +811,7 @@
     "debug": "debuggen",
     "debug_description": "Debug gibt zusätzliche Debuginformationen in die Konsole aus, um das Debuggen komplexer Abfragen zu erleichtern",
     "action": "Aktion",
-    "search": "Suchen",
-    "enter": "eingeben",
+    "search_button": "Suchen <kbd>Eingabetaste</kbd>",
     "search_execute": "Aktionen suchen und ausführen",
     "save_to_note": "Als Notiz speichern",
     "search_parameters": "Suchparameter",
diff --git a/src/public/translations/en/translation.json b/src/public/translations/en/translation.json
index 3add99720..f1d460b30 100644
--- a/src/public/translations/en/translation.json
+++ b/src/public/translations/en/translation.json
@@ -842,8 +842,7 @@
     "debug": "debug",
     "debug_description": "Debug will print extra debugging information into the console to aid in debugging complex queries",
     "action": "action",
-    "search": "Search",
-    "enter": "enter",
+    "search_button": "Search <kbd>enter</kbd>",
     "search_execute": "Search & Execute actions",
     "save_to_note": "Save to note",
     "search_parameters": "Search Parameters",
diff --git a/src/public/translations/es/translation.json b/src/public/translations/es/translation.json
index 849066fd3..474ba44ef 100644
--- a/src/public/translations/es/translation.json
+++ b/src/public/translations/es/translation.json
@@ -827,8 +827,7 @@
     "debug": "depurar",
     "debug_description": "La depuración imprimirá información de depuración adicional en la consola para ayudar a depurar consultas complejas",
     "action": "acción",
-    "search": "Buscar",
-    "enter": "ingresar",
+    "search_button": "Buscar <kbd>Enter</kbd>",
     "search_execute": "Buscar y ejecutar acciones",
     "save_to_note": "Guardar en nota",
     "search_parameters": "Parámetros de búsqueda",
diff --git a/src/public/translations/fr/translation.json b/src/public/translations/fr/translation.json
index e2573d3e0..b48a26637 100644
--- a/src/public/translations/fr/translation.json
+++ b/src/public/translations/fr/translation.json
@@ -812,8 +812,7 @@
     "debug": "debug",
     "debug_description": "Debug imprimera des informations supplémentaires dans la console pour faciliter le débogage des requêtes complexes",
     "action": "action",
-    "search": "Recherche",
-    "enter": "entrer",
+    "search_button": "Recherche <kbd>Entrée</kbd>",
     "search_execute": "Rechercher et exécuter des actions",
     "save_to_note": "Enregistrer dans la note",
     "search_parameters": "Paramètres de recherche",
diff --git a/src/public/translations/ro/translation.json b/src/public/translations/ro/translation.json
index fbe8807df..bf2bf0f32 100644
--- a/src/public/translations/ro/translation.json
+++ b/src/public/translations/ro/translation.json
@@ -1071,7 +1071,6 @@
     "ancestor": "ascendent",
     "debug": "depanare",
     "debug_description": "Modul de depanare va afișa informații adiționale în consolă pentru a ajuta la depanarea interogărilor complexe",
-    "enter": "enter",
     "fast_search": "căutare rapidă",
     "fast_search_description": "Căutarea rapidă dezactivează căutarea la nivel de conținut al notițelor cu scopul de a îmbunătăți performanța de căutare pentru baze de date mari.",
     "include_archived": "include arhivate",
@@ -1080,7 +1079,7 @@
     "limit_description": "Limitează numărul de rezultate",
     "order_by": "ordonează după",
     "save_to_note": "Salvează în notiță",
-    "search": "Căutare",
+    "search_button": "Căutare <kbd>Enter</kbd>",
     "search_execute": "Caută și execută acțiunile",
     "search_note_saved": "Notița de căutare a fost salvată în {{- notePathTitle}}",
     "search_parameters": "Parametrii de căutare",
diff --git a/src/public/translations/tw/translation.json b/src/public/translations/tw/translation.json
index 80b8973bd..600579ea5 100644
--- a/src/public/translations/tw/translation.json
+++ b/src/public/translations/tw/translation.json
@@ -816,8 +816,7 @@
     "debug": "除錯",
     "debug_description": "除錯將打印額外的除錯資訊到控制台，以幫助除錯複雜查詢",
     "action": "操作",
-    "search": "搜尋",
-    "enter": "輸入",
+    "search_button": "搜尋 <kbd>Enter</kbd>",
     "search_execute": "搜尋並執行操作",
     "save_to_note": "保存到筆記",
     "search_parameters": "搜尋參數",