Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-10-31 13:01:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

added isBeingDeleted to be able to recognize that note is being deleted while still leaving it accessible

Browse Source
This commit is contained in:
zadam 2022-12-06 16:11:43 +01:00
parent aec2c2d5cd
commit d64b575e60
3 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/becca/entities/attribute.js
View File

@ -113,7 +113,13 @@ class Attribute extends AbstractEntity {
* @returns {Note|null} * @returns {Note|null}
*/ */
getNote() { getNote() {
return this.becca.getNote(this.noteId); const note = this.becca.getNote(this.noteId);
if (!note) {
throw new Error(`Note '${this.noteId}' of attribute '${this.attributeId}', type '${this.type}', name '${this.name}' does not exist.`);
}
return note;
} }
/** /**

4
src/becca/entities/branch.js
View File

@ -187,9 +187,7 @@ class Branch extends AbstractEntity {
log.info("Deleting note " + note.noteId); log.info("Deleting note " + note.noteId);
// marking note as deleted as a signal to event handlers that the note is being deleted this.becca.notes[note.noteId].isBeingDeleted = true;
// (isDeleted is being checked against becca)
delete this.becca.notes[note.noteId];
for (const attribute of note.getOwnedAttributes()) { for (const attribute of note.getOwnedAttributes()) {
attribute.markAsDeleted(deleteId); attribute.markAsDeleted(deleteId);

4
src/becca/entities/note.js
View File

@ -72,6 +72,8 @@ class Note extends AbstractEntity {
this.utcDateCreated = utcDateCreated || dateUtils.utcNowDateTime(); this.utcDateCreated = utcDateCreated || dateUtils.utcNowDateTime();
/** @type {string} */ /** @type {string} */
this.utcDateModified = utcDateModified; this.utcDateModified = utcDateModified;
/** @type {boolean} - set during the deletion operation, before it is completed (removed from becca completely) */
this.isBeingDeleted = false;
// ------ Derived attributes ------ // ------ Derived attributes ------
@ -1327,7 +1329,7 @@ class Note extends AbstractEntity {
} }
get isDeleted() { get isDeleted() {
return !(this.noteId in this.becca.notes); return !(this.noteId in this.becca.notes) || this.isBeingDeleted;
} }
/** /**