From d2ee3738a2e6d053afefe957eb545b5ed026a68e Mon Sep 17 00:00:00 2001
From: SiriusXT <1160925501@qq.com>
Date: Wed, 6 Nov 2024 10:02:42 +0800
Subject: [PATCH] Make attachments open in a new tab/browser

---
 .../app/widgets/type_widgets/abstract_text_type_widget.js   | 6 +++---
 src/services/window.ts                                      | 6 +-----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/public/app/widgets/type_widgets/abstract_text_type_widget.js b/src/public/app/widgets/type_widgets/abstract_text_type_widget.js
index e78687356..92409eb1a 100644
--- a/src/public/app/widgets/type_widgets/abstract_text_type_widget.js
+++ b/src/public/app/widgets/type_widgets/abstract_text_type_widget.js
@@ -32,7 +32,7 @@ export default class AbstractTextTypeWidget extends TypeWidget {
 
     async openImageInCurrentTab($img) {
         const { noteId, viewScope } = await this.parseFromImage($img);
-
+        
         if (noteId) {
             appContext.tabManager.getActiveContext().setNote(noteId, { viewScope });
         } else {
@@ -40,8 +40,8 @@ export default class AbstractTextTypeWidget extends TypeWidget {
         }
     }
 
-    openImageInNewTab($img) {
-        const { noteId, viewScope } = this.parseFromImage($img);
+    async openImageInNewTab($img) {
+        const { noteId, viewScope } = await this.parseFromImage($img);
 
         if (noteId) {
             appContext.tabManager.openTabWithNoteWithHoisting(noteId, { viewScope });
diff --git a/src/services/window.ts b/src/services/window.ts
index dd64aeb00..d0c625a15 100644
--- a/src/services/window.ts
+++ b/src/services/window.ts
@@ -111,13 +111,9 @@ async function createMainWindow(app: App) {
 }
 
 function configureWebContents(webContents: WebContents, spellcheckEnabled: boolean) {
-    if (!mainWindow) {
-        return;
-    }
-
     remoteMain.enable(webContents);
 
-    mainWindow.webContents.setWindowOpenHandler((details) => {
+    webContents.setWindowOpenHandler((details) => {
         async function openExternal() {
             (await import('electron')).shell.openExternal(details.url);
         }