Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-09-28 16:01:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: Add override for methods

Browse Source 
ERROR in ckeditor5-math/src/mathcommand.ts
./src/mathcommand.ts 5:8-13
[tsl] ERROR in ckeditor5-math/src/mathcommand.ts(5,9)
      TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Command'.
 @ ./src/autoformatmath.ts 6:0-40 24:31-42
 @ ./src/index.ts 5:0-61 5:0-61

ERROR in ckeditor5-math/src/mathcommand.ts
./src/mathcommand.ts 6:8-15
[tsl] ERROR in ckeditor5-math/src/mathcommand.ts(6,9)
      TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Command'.
 @ ./src/autoformatmath.ts 6:0-40 24:31-42
 @ ./src/index.ts 5:0-61 5:0-61

ERROR in ckeditor5-math/src/mathcommand.ts
./src/mathcommand.ts 48:8-15
[tsl] ERROR in ckeditor5-math/src/mathcommand.ts(48,9)
      TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Command'.
 @ ./src/autoformatmath.ts 6:0-40 24:31-42
 @ ./src/index.ts 5:0-61 5:0-61

ERROR in ckeditor5-math/src/mathui.ts
./src/mathui.ts 41:8-15
[tsl] ERROR in ckeditor5-math/src/mathui.ts(41,9)
      TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Plugin'.
 @ ./src/autoformatmath.ts 7:0-30 33:50-56
 @ ./src/index.ts 5:0-61 5:0-61

ERROR in ckeditor5-math/src/ui/mainformview.ts
./src/ui/mainformview.ts 40:8-14
[tsl] ERROR in ckeditor5-math/src/ui/mainformview.ts(40,9)
      TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'View<HTMLElement>'.
 @ ./src/mathui.ts 2:0-45 61:29-41
 @ ./src/autoformatmath.ts 7:0-30 33:50-56
 @ ./src/index.ts 5:0-61 5:0-61

ERROR in ckeditor5-math/src/ui/mainformview.ts
./src/ui/mainformview.ts 130:8-14
[tsl] ERROR in ckeditor5-math/src/ui/mainformview.ts(130,9)
      TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'View<HTMLElement>'.
 @ ./src/mathui.ts 2:0-45 61:29-41
 @ ./src/autoformatmath.ts 7:0-30 33:50-56
 @ ./src/index.ts 5:0-61 5:0-61

ERROR in ckeditor5-math/src/ui/mathview.ts
./src/ui/mathview.ts 76:8-14
[tsl] ERROR in ckeditor5-math/src/ui/mathview.ts(76,9)
      TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'View<HTMLElement>'.
 @ ./src/ui/mainformview.ts 5:0-34 48:32-40
 @ ./src/mathui.ts 2:0-45 61:29-41
 @ ./src/autoformatmath.ts 7:0-30 33:50-56
 @ ./src/index.ts 5:0-61 5:0-61

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.
This commit is contained in:
Tony Narlock 2024-03-16 05:40:55 -05:00
parent 1beaf1a29c
commit d104feb697
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mathcommand.ts
View File

@ -2,8 +2,8 @@ import { Command } from 'ckeditor5/src/core';
import { getSelectedMathModelWidget } from './utils';
export default class MathCommand extends Command {
public value: string | null = null;
public execute(
public override value: string | null = null;
public override execute(
equation: string,
display?: boolean,
outputType: 'script' | 'span' = 'script',
@ -45,7 +45,7 @@ export default class MathCommand extends Command {
public display = false;
public refresh(): void {
public override refresh(): void {
const model = this.editor.model;
const selection = model.document.selection;
const selectedElement = selection.getSelectedElement();

2
src/mathui.ts
View File

@ -38,7 +38,7 @@ export default class MathUI extends Plugin {
this._enableUserBalloonInteractions();
}
public destroy(): void {
public override destroy(): void {
super.destroy();
this.formView?.destroy();

4
src/ui/mainformview.ts
View File

@ -37,7 +37,7 @@ export default class MainFormView extends View {
public previewEnabled: boolean;
public previewLabel?: LabelView;
public mathView?: MathView;
public locale: Locale = new Locale();
public override locale: Locale = new Locale();
public lazyLoad: undefined | ( () => Promise<void> );
constructor(
@ -127,7 +127,7 @@ export default class MainFormView extends View {
} );
}
public render(): void {
public override render(): void {
super.render();
// Prevent default form submit event & trigger custom 'submit'

2
src/ui/mathview.ts
View File

@ -73,7 +73,7 @@ export default class MathView extends View {
}
}
public render(): void {
public override render(): void {
super.render();
this.updateMath();
}