From ce83c918fb7f33cdfb1620416f5375640be4e73d Mon Sep 17 00:00:00 2001 From: Panagiotis Papadopoulos Date: Tue, 15 Apr 2025 09:09:28 +0200 Subject: [PATCH] fix(login): fix regression that removed support for setting custom cookieMaxAge regression introduced with #401 custom cookieMaxAge feature added with #1156 fixes #1709 --- src/routes/login.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/routes/login.ts b/src/routes/login.ts index 3f4d52f32..7c783bbe7 100644 --- a/src/routes/login.ts +++ b/src/routes/login.ts @@ -92,11 +92,10 @@ function login(req: Request, res: Response) { const rememberMe = req.body.rememberMe; req.session.regenerate(() => { - if (rememberMe) { - req.session.cookie.maxAge = 21 * 24 * 3600000; // 3 weeks - } else { + if (!rememberMe) { // unset default maxAge set by sessionParser - // Cookie becomes non-persistent and expires after current browser session (e.g. when browser is closed) + // Cookie becomes non-persistent and expires + // after current browser session (e.g. when browser is closed) req.session.cookie.maxAge = undefined; }