mirror of
				https://github.com/TriliumNext/Notes.git
				synced 2025-10-30 20:41:33 +08:00 
			
		
		
		
	server-ts: FIXME -> TODO
This commit is contained in:
		
							parent
							
								
									11c7533984
								
							
						
					
					
						commit
						cbc01e1a8d
					
				| @ -183,7 +183,7 @@ function noteUpdated(entityRow: NoteRow) { | |||||||
|     const note = becca.notes[entityRow.noteId]; |     const note = becca.notes[entityRow.noteId]; | ||||||
| 
 | 
 | ||||||
|     if (note) { |     if (note) { | ||||||
|         // FIXME, this wouldn't have worked in the original implementation since the variable was named __flatTextCache.
 |         // TODO, this wouldn't have worked in the original implementation since the variable was named __flatTextCache.
 | ||||||
|         // type / mime could have been changed, and they are present in flatTextCache
 |         // type / mime could have been changed, and they are present in flatTextCache
 | ||||||
|         note.__flatTextCache = null; |         note.__flatTextCache = null; | ||||||
|     } |     } | ||||||
|  | |||||||
| @ -104,7 +104,7 @@ abstract class AbstractBeccaEntity<T extends AbstractBeccaEntity<T>> { | |||||||
|     /** |     /** | ||||||
|      * Saves entity - executes SQL, but doesn't commit the transaction on its own |      * Saves entity - executes SQL, but doesn't commit the transaction on its own | ||||||
|      */ |      */ | ||||||
|     // FIXME: opts not used but called a few times, maybe should be used by derived classes or passed to beforeSaving.
 |     // TODO: opts not used but called a few times, maybe should be used by derived classes or passed to beforeSaving.
 | ||||||
|     save(opts?: {}): this { |     save(opts?: {}): this { | ||||||
|         const constructorData = (this.constructor as unknown as ConstructorData<T>); |         const constructorData = (this.constructor as unknown as ConstructorData<T>); | ||||||
|         const entityName = constructorData.entityName; |         const entityName = constructorData.entityName; | ||||||
|  | |||||||
| @ -10,7 +10,7 @@ import passwordService = require('./encryption/password'); | |||||||
| 
 | 
 | ||||||
| const noAuthentication = config.General && config.General.noAuthentication === true; | const noAuthentication = config.General && config.General.noAuthentication === true; | ||||||
| 
 | 
 | ||||||
| // FIXME: We are using custom types for request & response because couldn't extract those pesky express types.
 | // TODO: We are using custom types for request & response because couldn't extract those pesky express types.
 | ||||||
| interface Request { | interface Request { | ||||||
|     method: string; |     method: string; | ||||||
|     path: string; |     path: string; | ||||||
|  | |||||||
| @ -761,7 +761,7 @@ function updateNoteData(noteId: string, content: string, attachments: BAttachmen | |||||||
|         const existingAttachmentsByTitle = utils.toMap(note.getAttachments({includeContentLength: false}), 'title'); |         const existingAttachmentsByTitle = utils.toMap(note.getAttachments({includeContentLength: false}), 'title'); | ||||||
| 
 | 
 | ||||||
|         for (const attachment of attachments) { |         for (const attachment of attachments) { | ||||||
|             // FIXME: The content property was extracted directly instead of `getContent`. To investigate.
 |             // TODO: The content property was extracted directly instead of `getContent`. To investigate.
 | ||||||
|             const {attachmentId, role, mime, title, position} = attachment; |             const {attachmentId, role, mime, title, position} = attachment; | ||||||
|             const content = attachment.getContent(); |             const content = attachment.getContent(); | ||||||
| 
 | 
 | ||||||
| @ -834,7 +834,7 @@ function undeleteBranch(branchId: string, deleteId: string, taskContext: TaskCon | |||||||
| 
 | 
 | ||||||
|         for (const attributeRow of attributeRows) { |         for (const attributeRow of attributeRows) { | ||||||
|             // relation might point to a note which hasn't been undeleted yet and would thus throw up
 |             // relation might point to a note which hasn't been undeleted yet and would thus throw up
 | ||||||
|             // FIXME: skipValidation is not used.
 |             // TODO: skipValidation is not used.
 | ||||||
|             new BAttribute(attributeRow).save({skipValidation: true}); |             new BAttribute(attributeRow).save({skipValidation: true}); | ||||||
|         } |         } | ||||||
| 
 | 
 | ||||||
| @ -1014,7 +1014,7 @@ function duplicateSubtreeInner(origNote: BNote, origBranch: BBranch, newParentNo | |||||||
|             } |             } | ||||||
| 
 | 
 | ||||||
|             // the relation targets may not be created yet, the mapping is pre-generated
 |             // the relation targets may not be created yet, the mapping is pre-generated
 | ||||||
|             // FIXME: This used to be `attr.save({skipValidation: true});`, but skipValidation is in beforeSaving.
 |             // TODO: This used to be `attr.save({skipValidation: true});`, but skipValidation is in beforeSaving.
 | ||||||
|             attr.save(); |             attr.save(); | ||||||
|         } |         } | ||||||
| 
 | 
 | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Elian Doran
						Elian Doran