From c6b3cc78822eb497bbffa8a7de6be223c9898bd0 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Fri, 3 Jan 2025 19:58:45 +0200
Subject: [PATCH] chore(i18n): translate font selection headings

---
 .../type_widgets/options/appearance/fonts.ts  | 91 +++++++++++--------
 src/public/translations/en/translation.json   |  7 +-
 src/public/translations/ro/translation.json   |  7 +-
 3 files changed, 65 insertions(+), 40 deletions(-)

diff --git a/src/public/app/widgets/type_widgets/options/appearance/fonts.ts b/src/public/app/widgets/type_widgets/options/appearance/fonts.ts
index 875c0f64c..f91421090 100644
--- a/src/public/app/widgets/type_widgets/options/appearance/fonts.ts
+++ b/src/public/app/widgets/type_widgets/options/appearance/fonts.ts
@@ -3,41 +3,56 @@ import utils from "../../../../services/utils.js";
 import { t } from "../../../../services/i18n.js";
 import { OptionMap, OptionNames } from "../../../../../../services/options_interface.js";
 
-const FONT_FAMILIES = {
-    "Generic fonts": [
-        { value: "theme", label: t("fonts.theme_defined") },
-        { value: "serif", label: "Serif" },
-        { value: "sans-serif", label: "Sans Serif" },
-        { value: "monospace", label: "Monospace" },
-    ],
-    "Sans-serif system fonts": [
-        { value: "Arial", label: "Arial" },
-        { value: "Verdana", label: "Verdana" },
-        { value: "Helvetica", label: "Helvetica" },
-        { value: "Tahoma", label: "Tahoma" },
-        { value: "Trebuchet MS", label: "Trebuchet MS" },
-        { value: "Microsoft YaHei", label: "Microsoft YaHei" },
-    ],
-    "Serif system fonts": [
-        { value: "Times New Roman", label: "Times New Roman" },
-        { value: "Georgia", label: "Georgia" },
-        { value: "Garamond", label: "Garamond" },
-    ],
-    "Monospace system fonts": [
-        { value: "Courier New", label: "Courier New" },
-        { value: "Brush Script MT", label: "Brush Script MT" },
-        { value: "Impact", label: "Impact" },
-        { value: "American Typewriter", label: "American Typewriter" },
-        { value: "Andalé Mono", label: "Andalé Mono" },
-        { value: "Lucida Console", label: "Lucida Console" },
-        { value: "Monaco", label: "Monaco" },
-    ],
-    "Handwriting system fonts": [
-        { value: "Bradley Hand", label: "Bradley Hand" },
-        { value: "Luminari", label: "Luminari" },
-        { value: "Comic Sans MS", label: "Comic Sans MS" }
-    ]
-};
+const FONT_FAMILIES = [
+    {
+        title: t("fonts.generic-fonts"),
+        items: [
+            { value: "theme", label: t("fonts.theme_defined") },
+            { value: "serif", label: "Serif" },
+            { value: "sans-serif", label: "Sans Serif" },
+            { value: "monospace", label: "Monospace" },
+        ]
+    },
+    {
+        title: t("fonts.sans-serif-system-fonts"),
+        items: [
+            { value: "Arial", label: "Arial" },
+            { value: "Verdana", label: "Verdana" },
+            { value: "Helvetica", label: "Helvetica" },
+            { value: "Tahoma", label: "Tahoma" },
+            { value: "Trebuchet MS", label: "Trebuchet MS" },
+            { value: "Microsoft YaHei", label: "Microsoft YaHei" },
+        ]
+    },
+    {
+        title: t("fonts.serif-system-fonts"),
+        items: [
+            { value: "Times New Roman", label: "Times New Roman" },
+            { value: "Georgia", label: "Georgia" },
+            { value: "Garamond", label: "Garamond" },
+        ]
+    },
+    {
+        title: t("fonts.monospace-system-fonts"),
+        items: [
+            { value: "Courier New", label: "Courier New" },
+            { value: "Brush Script MT", label: "Brush Script MT" },
+            { value: "Impact", label: "Impact" },
+            { value: "American Typewriter", label: "American Typewriter" },
+            { value: "Andalé Mono", label: "Andalé Mono" },
+            { value: "Lucida Console", label: "Lucida Console" },
+            { value: "Monaco", label: "Monaco" },
+        ]
+    },
+    {
+        title: t("fonts.handwriting-system-fonts"),
+        items: [
+            { value: "Bradley Hand", label: "Bradley Hand" },
+            { value: "Luminari", label: "Luminari" },
+            { value: "Comic Sans MS", label: "Comic Sans MS" }
+        ]
+    }
+];
 
 const TPL = `
 <div class="options-section">
@@ -196,11 +211,11 @@ export default class FontsOptions extends OptionsWidget {
     fillFontFamilyOptions($select: JQuery<HTMLElement>, currentValue: string) {
         $select.empty();
 
-        for (const [group, fonts] of Object.entries(FONT_FAMILIES)) {
+        for (const { title, items } of Object.values(FONT_FAMILIES)) {
             $select.append($("<optgroup>")
-                .attr("label", group));
+                .attr("label", title));
 
-            for (const {value, label} of fonts) {
+            for (const {value, label} of items) {
                 $select.append($("<option>")
                     .attr("value", value)
                     .prop("selected", value === currentValue)
diff --git a/src/public/translations/en/translation.json b/src/public/translations/en/translation.json
index dcc7798b3..97ebcbdaf 100644
--- a/src/public/translations/en/translation.json
+++ b/src/public/translations/en/translation.json
@@ -1063,7 +1063,12 @@
     "note_tree_and_detail_font_sizing": "Note that tree and detail font sizing is relative to the main font size setting.",
     "not_all_fonts_available": "Not all listed fonts may be available on your system.",
     "apply_font_changes": "To apply font changes, click on",
-    "reload_frontend": "reload frontend"
+    "reload_frontend": "reload frontend",
+    "generic-fonts": "Generic fonts",
+    "sans-serif-system-fonts": "Sans-serif system fonts",
+    "serif-system-fonts": "Serif system fonts",
+    "monospace-system-fonts": "Monospace system fonts",
+    "handwriting-system-fonts": "Handwriting system fonts"
   },
   "max_content_width": {
     "title": "Content Width",
diff --git a/src/public/translations/ro/translation.json b/src/public/translations/ro/translation.json
index 375945176..3992dfb81 100644
--- a/src/public/translations/ro/translation.json
+++ b/src/public/translations/ro/translation.json
@@ -553,7 +553,12 @@
     "note_tree_font": "Fontul arborelui de notițe",
     "reload_frontend": "reîncarcă interfața",
     "size": "Mărime",
-    "theme_defined": "Definit de temă"
+    "theme_defined": "Definit de temă",
+    "generic-fonts": "Fonturi generice",
+    "handwriting-system-fonts": "Fonturi de sistem cu stil de scris de mână",
+    "monospace-system-fonts": "Fonturi de sistem monospațiu",
+    "sans-serif-system-fonts": "Fonturi de sistem fără serifuri",
+    "serif-system-fonts": "Fonturi de sistem cu serifuri"
   },
   "global_menu": {
     "about": "Despre TriliumNext Notes",