From 14358d1ec00887d7ba75b36d7e63491ac9df206c Mon Sep 17 00:00:00 2001
From: Panagiotis Papadopoulos <pano_90@gmx.net>
Date: Wed, 8 Jan 2025 09:15:16 +0100
Subject: [PATCH] refactor(views): use ejs partial for injecting window.glob

---
 src/routes/index.ts                 |  3 ++-
 src/views/desktop.ejs               | 24 +-----------------------
 src/views/mobile.ejs                | 21 +--------------------
 src/views/partials/windowGlobal.ejs | 23 +++++++++++++++++++++++
 4 files changed, 27 insertions(+), 44 deletions(-)
 create mode 100644 src/views/partials/windowGlobal.ejs

diff --git a/src/routes/index.ts b/src/routes/index.ts
index aa943267c..e9cde473a 100644
--- a/src/routes/index.ts
+++ b/src/routes/index.ts
@@ -34,6 +34,7 @@ function index(req: Request, res: Response) {
 
     const isElectron = utils.isElectron();
     res.render(view, {
+        device: view,
         csrfToken: csrfToken,
         themeCssUrl: getThemeCssUrl(theme, themeNote),
         themeUseNextAsBase: themeNote?.getAttributeValue("label", "appThemeBase") === "next",
@@ -51,7 +52,7 @@ function index(req: Request, res: Response) {
         instanceName: config.General ? config.General.instanceName : null,
         appCssNoteIds: getAppCssNoteIds(),
         isDev: env.isDev(),
-        isMainWindow: !req.query.extraWindow,
+        isMainWindow: (view === "mobile") ? true : !req.query.extraWindow,
         isProtectedSessionAvailable: protectedSessionService.isProtectedSessionAvailable(),
         maxContentWidth: Math.max(640, parseInt(options.maxContentWidth)),
         triliumVersion: packageJson.version,
diff --git a/src/views/desktop.ejs b/src/views/desktop.ejs
index 514f72695..f56f68eb6 100644
--- a/src/views/desktop.ejs
+++ b/src/views/desktop.ejs
@@ -21,29 +21,7 @@
 
 <div class="dropdown-menu dropdown-menu-sm" id="context-menu-container"></div>
 
-<script type="text/javascript">
-    global = globalThis; /* fixes https://github.com/webpack/webpack/issues/10035 */
-
-    window.glob = {
-        device: "desktop",
-        baseApiUrl: 'api/',
-        activeDialog: null,
-        maxEntityChangeIdAtLoad: <%= maxEntityChangeIdAtLoad %>,
-        maxEntityChangeSyncIdAtLoad: <%= maxEntityChangeSyncIdAtLoad %>,
-        instanceName: '<%= instanceName %>',
-        csrfToken: '<%= csrfToken %>',
-        isDev: <%= isDev %>,
-        appCssNoteIds: <%- JSON.stringify(appCssNoteIds) %>,
-        isMainWindow: <%= isMainWindow %>,
-        isProtectedSessionAvailable: <%= isProtectedSessionAvailable %>,
-        triliumVersion: "<%= triliumVersion %>",
-        assetPath: "<%= assetPath %>",
-        appPath: "<%= appPath %>",
-        platform: "<%= platform %>",
-        hasNativeTitleBar: <%= hasNativeTitleBar %>,
-        TRILIUM_SAFE_MODE: <%= !!process.env.TRILIUM_SAFE_MODE %>
-    };
-</script>
+<%- include("./partials/windowGlobal.ejs", locals) %>
 
 <style>
     .note-split {
diff --git a/src/views/mobile.ejs b/src/views/mobile.ejs
index 31c6a6802..7cb664c45 100644
--- a/src/views/mobile.ejs
+++ b/src/views/mobile.ejs
@@ -106,26 +106,7 @@
 
 <div class="dropdown-menu dropdown-menu-sm" id="context-menu-container"></div>
 
-<script type="text/javascript">
-    global = globalThis; /* fixes https://github.com/webpack/webpack/issues/10035 */
-
-    window.glob = {
-        device: "mobile",
-        baseApiUrl: 'api/',
-        activeDialog: null,
-        maxEntityChangeIdAtLoad: <%= maxEntityChangeIdAtLoad %>,
-        maxEntityChangeSyncIdAtLoad: <%= maxEntityChangeSyncIdAtLoad %>,
-        instanceName: '<%= instanceName %>',
-        csrfToken: '<%= csrfToken %>',
-        isDev: <%= isDev %>,
-        appCssNoteIds: <%- JSON.stringify(appCssNoteIds) %>,
-        isMainWindow: true,
-        isProtectedSessionAvailable: <%= isProtectedSessionAvailable %>,
-        assetPath: "<%= assetPath %>",
-        appPath: "<%= appPath %>",
-        TRILIUM_SAFE_MODE: <%= !!process.env.TRILIUM_SAFE_MODE %>
-    };
-</script>
+<%- include("./partials/windowGlobal.ejs", locals) %>
 
 <script src="<%= assetPath %>/node_modules/jquery/dist/jquery.min.js"></script>
 
diff --git a/src/views/partials/windowGlobal.ejs b/src/views/partials/windowGlobal.ejs
new file mode 100644
index 000000000..1258030d1
--- /dev/null
+++ b/src/views/partials/windowGlobal.ejs
@@ -0,0 +1,23 @@
+<script type="text/javascript">
+    global = globalThis; /* fixes https://github.com/webpack/webpack/issues/10035 */
+
+    window.glob = {
+        device: "<%= device %>",
+        baseApiUrl: 'api/',
+        activeDialog: null,
+        maxEntityChangeIdAtLoad: <%= maxEntityChangeIdAtLoad %>,
+        maxEntityChangeSyncIdAtLoad: <%= maxEntityChangeSyncIdAtLoad %>,
+        instanceName: '<%= instanceName %>',
+        csrfToken: '<%= csrfToken %>',
+        isDev: <%= isDev %>,
+        appCssNoteIds: <%- JSON.stringify(appCssNoteIds) %>,
+        isMainWindow: <%= isMainWindow %>,
+        isProtectedSessionAvailable: <%= isProtectedSessionAvailable %>,
+        triliumVersion: "<%= triliumVersion %>",
+        assetPath: "<%= assetPath %>",
+        appPath: "<%= appPath %>",
+        platform: "<%= platform %>",
+        hasNativeTitleBar: <%= hasNativeTitleBar %>,
+        TRILIUM_SAFE_MODE: <%= !!process.env.TRILIUM_SAFE_MODE %>
+    };
+</script>
\ No newline at end of file