From b1bda646c416742f395fad4bc888d286f7f4ba35 Mon Sep 17 00:00:00 2001 From: Logan Gorence Date: Sun, 6 Oct 2019 20:59:46 -0700 Subject: [PATCH] Fix imageless posts when taking a screenshot on an internal page. --- background.js | 2 +- bin/release-chrome.sh | 1 + bin/release-firefox.sh | 3 ++- bin/release.sh | 1 + 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/background.js b/background.js index 4e323a735..9b8c36ded 100644 --- a/background.js +++ b/background.js @@ -91,7 +91,7 @@ async function sendMessageToActiveTab(message) { return await browser.tabs.sendMessage(activeTab.id, message); } catch (e) { - console.error("Sending message to active tab failed, you might need to refresh the page after updating the extension.", e); + throw e; } } diff --git a/bin/release-chrome.sh b/bin/release-chrome.sh index 6981fb6ae..b3e200b1a 100755 --- a/bin/release-chrome.sh +++ b/bin/release-chrome.sh @@ -1,4 +1,5 @@ #!/usr/bin/env bash +set -e VERSION=$(jq -r ".version" manifest.json) CHROME_EXTENSION_ID=dfhgmnfclbebfobmblelddiejjcijbjm diff --git a/bin/release-firefox.sh b/bin/release-firefox.sh index dad0e900a..d26684f9e 100755 --- a/bin/release-firefox.sh +++ b/bin/release-firefox.sh @@ -1,4 +1,5 @@ #!/usr/bin/env bash +set -e WEB_EXT_ID="{1410742d-b377-40e7-a9db-63dc9c6ec99c}" @@ -17,4 +18,4 @@ jq '.name = "Trilium Web Clipper"' manifest.json | sponge manifest.json web-ext sign --id ${WEB_EXT_ID} --artifacts-dir ../ cd .. -rm -r "${ARTIFACT_NAME}" \ No newline at end of file +rm -r "${ARTIFACT_NAME}" diff --git a/bin/release.sh b/bin/release.sh index 93e16ff98..7aa982fa0 100755 --- a/bin/release.sh +++ b/bin/release.sh @@ -1,4 +1,5 @@ #!/usr/bin/env bash +set -e export GITHUB_REPO=trilium-web-clipper