diff --git a/src/public/app/components/app_context.ts b/src/public/app/components/app_context.ts index a8616b1c6..105af75f6 100644 --- a/src/public/app/components/app_context.ts +++ b/src/public/app/components/app_context.ts @@ -296,7 +296,7 @@ type EventMappings = { noteContext: NoteContext; notePath?: string | null; }; - noteSwitchedAndActivatedEvent: { + noteSwitchedAndActivated: { noteContext: NoteContext; notePath: string; }; @@ -326,7 +326,7 @@ type EventMappings = { noteId: string; ntxId: string | null; }; - contextsReopenedEvent: { + contextsReopened: { mainNtxId: string | null; tabPosition: number; }; @@ -362,7 +362,7 @@ type EventMappings = { relationMapResetPanZoom: { ntxId: string | null | undefined }; relationMapResetZoomIn: { ntxId: string | null | undefined }; relationMapResetZoomOut: { ntxId: string | null | undefined }; - activeNoteChangedEvent: {}; + activeNoteChanged: {}; showAddLinkDialog: { textTypeWidget: EditableTextTypeWidget; text: string; diff --git a/src/public/app/components/tab_manager.ts b/src/public/app/components/tab_manager.ts index b441c7819..f222a4655 100644 --- a/src/public/app/components/tab_manager.ts +++ b/src/public/app/components/tab_manager.ts @@ -163,7 +163,7 @@ export default class TabManager extends Component { const activeNoteContext = this.getActiveContext(); this.updateDocumentTitle(activeNoteContext); - this.triggerEvent("activeNoteChangedEvent", {}); // trigger this even in on popstate event + this.triggerEvent("activeNoteChanged", {}); // trigger this even in on popstate event } calculateHash(): string { @@ -338,7 +338,6 @@ export default class TabManager extends Component { const viewScope = opts.viewScope || { viewMode: "default" }; const noteContext = await this.openEmptyTab(ntxId, hoistedNoteId, mainNtxId); - if (notePath) { await noteContext.setNote(notePath, { // if activate is false, then send normal noteSwitched event @@ -350,7 +349,7 @@ export default class TabManager extends Component { if (activate && noteContext.notePath) { this.activateNoteContext(noteContext.ntxId, false); - await this.triggerEvent("noteSwitchedAndActivatedEvent", { + await this.triggerEvent("noteSwitchedAndActivated", { noteContext, notePath: noteContext.notePath // resolved note path }); @@ -647,13 +646,13 @@ export default class TabManager extends Component { let mainNtx = noteContexts.find((nc) => nc.isMainContext()); if (mainNtx) { // reopened a tab, need to reorder new tab widget in tab row - await this.triggerEvent("contextsReopenedEvent", { + await this.triggerEvent("contextsReopened", { mainNtxId: mainNtx.ntxId, tabPosition: ntxsInOrder.filter((nc) => nc.isMainContext()).findIndex((nc) => nc.ntxId === mainNtx.ntxId) }); } else { // reopened a single split, need to reorder the pane widget in split note container - await this.triggerEvent("contextsReopenedEvent", { + await this.triggerEvent("contextsReopened", { mainNtxId: ntxsInOrder[lastClosedTab.position].ntxId, // this is safe since lastClosedTab.position can never be 0 in this case tabPosition: lastClosedTab.position - 1 diff --git a/src/public/app/widgets/containers/scrolling_container.ts b/src/public/app/widgets/containers/scrolling_container.ts index 62d4ec2c4..fab51254c 100644 --- a/src/public/app/widgets/containers/scrolling_container.ts +++ b/src/public/app/widgets/containers/scrolling_container.ts @@ -24,7 +24,7 @@ export default class ScrollingContainer extends Container { this.$widget.scrollTop(0); } - async noteSwitchedAndActivatedEvent({ noteContext, notePath }: EventData<"noteSwitchedAndActivatedEvent">) { + async noteSwitchedAndActivatedEvent({ noteContext, notePath }: EventData<"noteSwitchedAndActivated">) { this.noteContext = noteContext; this.$widget.scrollTop(0); diff --git a/src/public/app/widgets/containers/split_note_container.ts b/src/public/app/widgets/containers/split_note_container.ts index 9b828120b..8e686476c 100644 --- a/src/public/app/widgets/containers/split_note_container.ts +++ b/src/public/app/widgets/containers/split_note_container.ts @@ -199,7 +199,7 @@ export default class SplitNoteContainer extends FlexContainer { return Promise.resolve(); } - if (widget.hasBeenAlreadyShown || name === "noteSwitchedAndActivatedEvent" || appContext.tabManager.getActiveMainContext() === noteContext.getMainContext()) { + if (widget.hasBeenAlreadyShown || name === "noteSwitchedAndActivated" || appContext.tabManager.getActiveMainContext() === noteContext.getMainContext()) { widget.hasBeenAlreadyShown = true; return Promise.all([ diff --git a/src/public/app/widgets/note_context_aware_widget.ts b/src/public/app/widgets/note_context_aware_widget.ts index 3c1153c2f..639061f38 100644 --- a/src/public/app/widgets/note_context_aware_widget.ts +++ b/src/public/app/widgets/note_context_aware_widget.ts @@ -105,7 +105,7 @@ class NoteContextAwareWidget extends BasicWidget { } // when note is both switched and activated, this should not produce a double refresh - async noteSwitchedAndActivatedEvent({ noteContext, notePath }: EventData<"noteSwitchedAndActivatedEvent">) { + async noteSwitchedAndActivatedEvent({ noteContext, notePath }: EventData<"noteSwitchedAndActivated">) { this.noteContext = noteContext; // if notePath does not match, then the noteContext has been switched to another note in the meantime diff --git a/src/public/app/widgets/tab_row.ts b/src/public/app/widgets/tab_row.ts index c726cc528..b2cf11fd8 100644 --- a/src/public/app/widgets/tab_row.ts +++ b/src/public/app/widgets/tab_row.ts @@ -628,7 +628,7 @@ export default class TabRowWidget extends BasicWidget { return closestIndex; } - noteSwitchedAndActivatedEvent({ noteContext }: EventData<"noteSwitchedAndActivatedEvent">) { + noteSwitchedAndActivatedEvent({ noteContext }: EventData<"noteSwitchedAndActivated">) { this.activeContextChangedEvent(); this.updateTabById(noteContext.mainNtxId || noteContext.ntxId); @@ -649,7 +649,7 @@ export default class TabRowWidget extends BasicWidget { this.updateTabById(newMainNtxId); } - contextsReopenedEvent({ mainNtxId, tabPosition }: EventData<"contextsReopenedEvent">) { + contextsReopenedEvent({ mainNtxId, tabPosition }: EventData<"contextsReopened">) { if (!mainNtxId || !tabPosition) { // no tab reopened return;