Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-08-02 05:02:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(client): drop down no longer hiding when it should

Browse Source
This commit is contained in:
Elian Doran 2024-12-28 10:35:10 +02:00
parent 85f7d90c90
commit a28dff7525
No known key found for this signature in database
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/public/app/menus/context_menu.ts
View File

@ -46,9 +46,9 @@ class ContextMenu {
this.isMobile = utils.isMobile(); this.isMobile = utils.isMobile();
if (this.isMobile) { if (this.isMobile) {
this.$cover.on("click", this.hide); this.$cover.on("click", () => this.hide());
} else { } else {
$(document).on('click', (e) => this.hide); $(document).on('click', (e) => this.hide());
} }
} }
@ -218,7 +218,6 @@ class ContextMenu {
// this date checking comes from change in FF66 - https://github.com/zadam/trilium/issues/468 // this date checking comes from change in FF66 - https://github.com/zadam/trilium/issues/468
// "contextmenu" event also triggers "click" event which depending on the timing can close the just opened context menu // "contextmenu" event also triggers "click" event which depending on the timing can close the just opened context menu
// we might filter out right clicks, but then it's better if even right clicks close the context menu // we might filter out right clicks, but then it's better if even right clicks close the context menu
console.warn(new Error());
if (Date.now() - this.dateContextMenuOpenedMs > 300) { if (Date.now() - this.dateContextMenuOpenedMs > 300) {
// seems like if we hide the menu immediately, some clicks can get propagated to the underlying component // seems like if we hide the menu immediately, some clicks can get propagated to the underlying component
// see https://github.com/zadam/trilium/pull/3805 for details // see https://github.com/zadam/trilium/pull/3805 for details