From 85cfc8fbd4d940b6928b5bb30e053615db095ebf Mon Sep 17 00:00:00 2001
From: perf3ct <jonfuller2012@gmail.com>
Date: Fri, 6 Jun 2025 19:22:39 +0000
Subject: [PATCH] feat(llm): have OpenAI provider not require API keys (for
 endpoints like LM Studio)

---
 .../client/src/widgets/llm_chat/validation.ts |  2 +-
 apps/server/src/routes/api/openai.ts          | 11 +++----
 .../services/llm/providers/openai_service.ts  |  6 ++--
 .../src/services/llm/providers/providers.ts   | 30 ++++++++++++-------
 4 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/apps/client/src/widgets/llm_chat/validation.ts b/apps/client/src/widgets/llm_chat/validation.ts
index e39b07012..94977f63a 100644
--- a/apps/client/src/widgets/llm_chat/validation.ts
+++ b/apps/client/src/widgets/llm_chat/validation.ts
@@ -44,7 +44,7 @@ export async function validateEmbeddingProviders(validationWarning: HTMLElement)
                 // Check OpenAI configuration
                 const apiKey = options.get('openaiApiKey');
                 if (!apiKey) {
-                    configIssues.push(`OpenAI API key is missing`);
+                    configIssues.push(`OpenAI API key is missing (optional for OpenAI-compatible endpoints)`);
                 }
             } else if (provider === 'anthropic') {
                 // Check Anthropic configuration
diff --git a/apps/server/src/routes/api/openai.ts b/apps/server/src/routes/api/openai.ts
index ced03ce04..84efad2ca 100644
--- a/apps/server/src/routes/api/openai.ts
+++ b/apps/server/src/routes/api/openai.ts
@@ -66,12 +66,13 @@ async function listModels(req: Request, res: Response) {
         const apiKey = await options.getOption('openaiApiKey');
 
         if (!apiKey) {
-            throw new Error('OpenAI API key is not configured');
+            // Log warning but don't throw - some OpenAI-compatible endpoints don't require API keys
+            log.info('OpenAI API key is not configured when listing models. This may cause issues with official OpenAI endpoints.');
         }
 
-        // Initialize OpenAI client with the API key and base URL
+        // Initialize OpenAI client with the API key (or empty string) and base URL
         const openai = new OpenAI({
-            apiKey,
+            apiKey: apiKey || '', // Default to empty string if no API key
             baseURL: openaiBaseUrl
         });
 
@@ -84,9 +85,9 @@ async function listModels(req: Request, res: Response) {
         // Include all models as chat models, without filtering by specific model names
         // This allows models from providers like OpenRouter to be displayed
         const chatModels = allModels
-            .filter((model) => 
+            .filter((model) =>
                 // Exclude models that are explicitly for embeddings
-                !model.id.includes('embedding') && 
+                !model.id.includes('embedding') &&
                 !model.id.includes('embed')
             )
             .map((model) => ({
diff --git a/apps/server/src/services/llm/providers/openai_service.ts b/apps/server/src/services/llm/providers/openai_service.ts
index 09d58498a..411f512f7 100644
--- a/apps/server/src/services/llm/providers/openai_service.ts
+++ b/apps/server/src/services/llm/providers/openai_service.ts
@@ -14,7 +14,9 @@ export class OpenAIService extends BaseAIService {
     }
 
     override isAvailable(): boolean {
-        return super.isAvailable() && !!options.getOption('openaiApiKey');
+        // Make API key optional to support OpenAI-compatible endpoints that don't require authentication
+        // The provider is considered available as long as the parent checks pass
+        return super.isAvailable();
     }
 
     private getClient(apiKey: string, baseUrl?: string): OpenAI {
@@ -29,7 +31,7 @@ export class OpenAIService extends BaseAIService {
 
     async generateChatCompletion(messages: Message[], opts: ChatCompletionOptions = {}): Promise<ChatResponse> {
         if (!this.isAvailable()) {
-            throw new Error('OpenAI service is not available. Check API key and AI settings.');
+            throw new Error('OpenAI service is not available. Check AI settings.');
         }
 
         // Get provider-specific options from the central provider manager
diff --git a/apps/server/src/services/llm/providers/providers.ts b/apps/server/src/services/llm/providers/providers.ts
index 2fe64735a..fd7c603fd 100644
--- a/apps/server/src/services/llm/providers/providers.ts
+++ b/apps/server/src/services/llm/providers/providers.ts
@@ -134,7 +134,7 @@ export async function createProvidersFromCurrentOptions(): Promise<EmbeddingProv
         const ollamaEmbeddingBaseUrl = await options.getOption('ollamaEmbeddingBaseUrl');
         if (ollamaEmbeddingBaseUrl) {
             const embeddingModel = await options.getOption('ollamaEmbeddingModel');
-            
+
             try {
                 const ollamaProvider = new OllamaEmbeddingProvider({
                     model: embeddingModel,
@@ -152,23 +152,30 @@ export async function createProvidersFromCurrentOptions(): Promise<EmbeddingProv
             }
         }
 
-        // Create OpenAI provider if API key is configured
+        // Create OpenAI provider even without API key (for OpenAI-compatible endpoints)
         const openaiApiKey = await options.getOption('openaiApiKey');
-        if (openaiApiKey) {
-            const openaiModel = await options.getOption('openaiEmbeddingModel') || 'text-embedding-3-small';
-            const openaiBaseUrl = await options.getOption('openaiBaseUrl') || 'https://api.openai.com/v1';
+        const openaiBaseUrl = await options.getOption('openaiBaseUrl');
+
+        // Only create OpenAI provider if base URL is set or API key is provided
+        if (openaiApiKey || openaiBaseUrl) {
+            const openaiModel = await options.getOption('openaiEmbeddingModel')
+            const finalBaseUrl = openaiBaseUrl || 'https://api.openai.com/v1';
+
+            if (!openaiApiKey) {
+                log.info('Creating OpenAI embedding provider without API key. This may cause issues with official OpenAI endpoints.');
+            }
 
             const openaiProvider = new OpenAIEmbeddingProvider({
                 model: openaiModel,
                 dimension: 1536,
                 type: 'float32',
-                apiKey: openaiApiKey,
-                baseUrl: openaiBaseUrl
+                apiKey: openaiApiKey || '', // Default to empty string
+                baseUrl: finalBaseUrl
             });
 
             registerEmbeddingProvider(openaiProvider);
             result.push(openaiProvider);
-            log.info(`Created OpenAI provider on-demand: ${openaiModel}`);
+            log.info(`Created OpenAI provider on-demand: ${openaiModel} at ${finalBaseUrl}`);
         }
 
         // Create Voyage provider if API key is configured
@@ -221,7 +228,7 @@ export async function getEnabledEmbeddingProviders(): Promise<EmbeddingProvider[
 
     // First try to get existing registered providers
     const existingProviders = Array.from(providers.values());
-    
+
     // If no providers are registered, create them on-demand from current options
     if (existingProviders.length === 0) {
         log.info('No providers registered, creating from current options');
@@ -352,7 +359,8 @@ export function getOpenAIOptions(
     try {
         const apiKey = options.getOption('openaiApiKey');
         if (!apiKey) {
-            throw new Error('OpenAI API key is not configured');
+            // Log warning but don't throw - some OpenAI-compatible endpoints don't require API keys
+            log.info('OpenAI API key is not configured. This may cause issues with official OpenAI endpoints.');
         }
 
         const baseUrl = options.getOption('openaiBaseUrl') || PROVIDER_CONSTANTS.OPENAI.BASE_URL;
@@ -377,7 +385,7 @@ export function getOpenAIOptions(
 
         return {
             // Connection settings
-            apiKey,
+            apiKey: apiKey || '', // Default to empty string if no API key
             baseUrl,
 
             // Provider metadata