From 512440684e379cc8fc6cba56f453a5920bfe3584 Mon Sep 17 00:00:00 2001 From: perfectra1n Date: Sun, 2 Feb 2025 10:19:21 -0800 Subject: [PATCH 1/2] remove `mac_init` functionality as it was overriding paste (and other) functionality, and is no longer needed --- src/public/app/desktop.ts | 3 --- src/public/app/services/mac_init.ts | 14 -------------- src/public/app/setup.ts | 3 --- 3 files changed, 20 deletions(-) diff --git a/src/public/app/desktop.ts b/src/public/app/desktop.ts index 4e9930d34..b78074126 100644 --- a/src/public/app/desktop.ts +++ b/src/public/app/desktop.ts @@ -4,7 +4,6 @@ import noteTooltipService from "./services/note_tooltip.js"; import bundleService from "./services/bundle.js"; import toastService from "./services/toast.js"; import noteAutocompleteService from "./services/note_autocomplete.js"; -import macInit from "./services/mac_init.js"; import electronContextMenu from "./menus/electron_context_menu.js"; import glob from "./services/glob.js"; import { t } from "./services/i18n.js"; @@ -35,8 +34,6 @@ if (utils.isElectron()) { initOnElectron(); } -macInit.init(); - noteTooltipService.setupGlobalTooltip(); noteAutocompleteService.init(); diff --git a/src/public/app/services/mac_init.ts b/src/public/app/services/mac_init.ts index c864b3cad..46a59aeea 100644 --- a/src/public/app/services/mac_init.ts +++ b/src/public/app/services/mac_init.ts @@ -5,20 +5,6 @@ import utils from "./utils.js"; import shortcutService from "./shortcuts.js"; function init() { - if (utils.isElectron() && utils.isMac()) { - shortcutService.bindGlobalShortcut("meta+c", () => exec("copy")); - shortcutService.bindGlobalShortcut("meta+v", () => exec("paste")); - shortcutService.bindGlobalShortcut("meta+x", () => exec("cut")); - shortcutService.bindGlobalShortcut("meta+a", () => exec("selectAll")); - shortcutService.bindGlobalShortcut("meta+z", () => exec("undo")); - shortcutService.bindGlobalShortcut("meta+y", () => exec("redo")); - } -} - -function exec(cmd: string) { - document.execCommand(cmd); - - return false; } export default { diff --git a/src/public/app/setup.ts b/src/public/app/setup.ts index ec389c793..1970c110a 100644 --- a/src/public/app/setup.ts +++ b/src/public/app/setup.ts @@ -1,9 +1,6 @@ import utils from "./services/utils.js"; -import macInit from "./services/mac_init.js"; import ko from "knockout"; -macInit.init(); - // TriliumNextTODO: properly make use of below types // type SetupModelSetupType = "new-document" | "sync-from-desktop" | "sync-from-server" | ""; // type SetupModelStep = "sync-in-progress" | "setup-type" | "new-document-in-progress" | "sync-from-desktop"; From 363360f0d555ad8a94d0fd2887deca30c24287a0 Mon Sep 17 00:00:00 2001 From: perfectra1n Date: Sun, 2 Feb 2025 10:21:59 -0800 Subject: [PATCH 2/2] we can just remove mac_init now since we're not using it --- src/public/app/services/mac_init.ts | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 src/public/app/services/mac_init.ts diff --git a/src/public/app/services/mac_init.ts b/src/public/app/services/mac_init.ts deleted file mode 100644 index 46a59aeea..000000000 --- a/src/public/app/services/mac_init.ts +++ /dev/null @@ -1,12 +0,0 @@ -/** - * Mac specific initialization - */ -import utils from "./utils.js"; -import shortcutService from "./shortcuts.js"; - -function init() { -} - -export default { - init -};