From 7ade4010185a2ba133d07fc928cfcef3dc126415 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Sat, 8 Mar 2025 03:02:25 +0200
Subject: [PATCH] feat(eslint): downgrade unused variables to warning

---
 src/public/app/services/eslint.spec.ts | 19 +++++++++++++++++++
 src/public/app/services/eslint.ts      |  6 ++++--
 2 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/src/public/app/services/eslint.spec.ts b/src/public/app/services/eslint.spec.ts
index 7070e8a69..cc21746bd 100644
--- a/src/public/app/services/eslint.spec.ts
+++ b/src/public/app/services/eslint.spec.ts
@@ -26,4 +26,23 @@ describe("Linter", () => {
         `);
         expect(result.length).toBe(0);
     });
+
+    it("reports unused functions as warnings", async () => {
+        const result = await lint(trimIndentation`
+            function hello() { }
+            function world() { }
+
+            console.log("Hello world");
+        `);
+        expect(result).toMatchObject([
+            {
+                message: "'hello' is defined but never used.",
+                severity: 1
+            },
+            {
+                message: "'world' is defined but never used.",
+                severity: 1
+            }
+        ]);
+    });
 });
diff --git a/src/public/app/services/eslint.ts b/src/public/app/services/eslint.ts
index c8b035a58..33949b116 100644
--- a/src/public/app/services/eslint.ts
+++ b/src/public/app/services/eslint.ts
@@ -14,9 +14,11 @@ export async function lint(code: string) {
                 globals: {
                     ...globals.browser,
                     api: "readonly"
-                }
+                },
             },
-            rules: { }
+            rules: {
+                "no-unused-vars": [ "warn", { vars: "local", args: "after-used" }]
+            }
         }
     ]);