Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-10-31 13:01:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix doubling of notes after some actions

Browse Source
This commit is contained in:
azivner 2018-11-18 23:01:48 +01:00
parent 05e9669eaf
commit 49bca04ebb
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/public/javascripts/services/note_detail_relation_map.js
View File

@ -117,6 +117,15 @@ async function show() {
} }
function clearMap() {
// delete all endpoints and connections
// this is done at this point (after async operations) to reduce flicker to the minimum
jsPlumbInstance.deleteEveryEndpoint();
// without this we still end up with note boxes remaining in the canvas
$relationMapContainer.empty();
}
async function loadNotesAndRelations() { async function loadNotesAndRelations() {
const noteIds = mapData.notes.map(note => note.noteId); const noteIds = mapData.notes.map(note => note.noteId);
const data = await server.post("notes/relation-map", {noteIds}); const data = await server.post("notes/relation-map", {noteIds});
@ -142,11 +151,9 @@ async function loadNotesAndRelations() {
mapData.notes = mapData.notes.filter(note => note.noteId in data.noteTitles); mapData.notes = mapData.notes.filter(note => note.noteId in data.noteTitles);
// delete all endpoints and connections
// this is done at this point (after async operations) to reduce flicker to the minimum
jsPlumbInstance.deleteEveryEndpoint();
jsPlumbInstance.batch(async function () { jsPlumbInstance.batch(async function () {
clearMap();
for (const note of mapData.notes) { for (const note of mapData.notes) {
const title = data.noteTitles[note.noteId]; const title = data.noteTitles[note.noteId];
@ -244,11 +251,7 @@ function saveCurrentTransform() {
function cleanup() { function cleanup() {
if (jsPlumbInstance) { if (jsPlumbInstance) {
// delete all endpoints and connections clearMap();
jsPlumbInstance.deleteEveryEndpoint();
// without this we still end up with note boxes remaining in the canvas
$relationMapContainer.empty();
} }
if (pzInstance) { if (pzInstance) {