Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-08-11 11:02:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(note_language): rebuild editor when language is switched

Browse Source
This commit is contained in:
Elian Doran 2025-03-04 20:34:36 +02:00
parent c6b3c1bf88
commit 427b7fe992
No known key found for this signature in database
1 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/public/app/widgets/type_widgets/editable_text.js
View File

@ -16,6 +16,7 @@ import toast from "../../services/toast.js";
import { getMermaidConfig } from "../mermaid.js"; import { getMermaidConfig } from "../mermaid.js";
import { normalizeMimeTypeForCKEditor } from "../../services/mime_type_definitions.js"; import { normalizeMimeTypeForCKEditor } from "../../services/mime_type_definitions.js";
import { buildConfig, buildToolbarConfig } from "./ckeditor/toolbars.js"; import { buildConfig, buildToolbarConfig } from "./ckeditor/toolbars.js";
import attributes from "../../services/attributes.js";
const ENABLE_INSPECTOR = false; const ENABLE_INSPECTOR = false;
@ -140,8 +141,6 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget {
const isClassicEditor = utils.isMobile() || options.get("textNoteEditorType") === "ckeditor-classic"; const isClassicEditor = utils.isMobile() || options.get("textNoteEditorType") === "ckeditor-classic";
const editorClass = isClassicEditor ? CKEditor.DecoupledEditor : CKEditor.BalloonEditor; const editorClass = isClassicEditor ? CKEditor.DecoupledEditor : CKEditor.BalloonEditor;
const codeBlockLanguages = buildListOfLanguages();
// CKEditor since version 12 needs the element to be visible before initialization. At the same time, // CKEditor since version 12 needs the element to be visible before initialization. At the same time,
// we want to avoid flicker - i.e., show editor only once everything is ready. That's why we have separate // we want to avoid flicker - i.e., show editor only once everything is ready. That's why we have separate
// display of $widget in both branches. // display of $widget in both branches.
@ -252,11 +251,15 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget {
return editor; return editor;
}); });
await this.createEditor();
}
async createEditor() {
await this.watchdog.create(this.$editor[0], { await this.watchdog.create(this.$editor[0], {
placeholder: t("editable_text.placeholder"), placeholder: t("editable_text.placeholder"),
mention: mentionSetup, mention: mentionSetup,
codeBlock: { codeBlock: {
languages: codeBlockLanguages languages: buildListOfLanguages()
}, },
math: { math: {
engine: "katex", engine: "katex",
@ -478,4 +481,28 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget {
async refreshIncludedNoteEvent({ noteId }) { async refreshIncludedNoteEvent({ noteId }) {
this.refreshIncludedNote(this.$editor, noteId); this.refreshIncludedNote(this.$editor, noteId);
} }
async reinitialize() {
if (!this.watchdog) {
return;
}
const data = this.watchdog.editor.getData();
this.watchdog.destroy();
await this.createEditor();
this.watchdog.editor.setData(data);
}
async entitiesReloadedEvent(e) {
if (e.loadResults.getAttributeRows().find((attr) =>
attr.type === "label" &&
attr.name === "language" &&
attributes.isAffecting(attr, this.note)))
{
await this.reinitialize();
}
super.entitiesReloadedEvent(e);
}
} }