Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-07-27 18:12:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(signing): use environment variables for the executable path

Browse Source
This commit is contained in:
Elian Doran 2025-03-24 17:00:37 +02:00
parent 3413c5e401
commit 34043a8a70
No known key found for this signature in database
3 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/actions/build-electron/action.yml vendored
View File

@ -79,6 +79,7 @@ runs:
APPLE_TEAM_ID: ${{ env.APPLE_TEAM_ID }} APPLE_TEAM_ID: ${{ env.APPLE_TEAM_ID }}
APPLE_ID: ${{ env.APPLE_ID }} APPLE_ID: ${{ env.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ env.APPLE_ID_PASSWORD }} APPLE_ID_PASSWORD: ${{ env.APPLE_ID_PASSWORD }}
WINDOWS_SIGN_EXECUTABLE: ${{ env.WINDOWS_SIGN_EXECUTABLE }}
run: | run: |
npm run electron-forge:make -- \ npm run electron-forge:make -- \
--arch=${{ inputs.arch }} \ --arch=${{ inputs.arch }} \

1
.github/workflows/nightly.yml vendored
View File

@ -50,6 +50,7 @@ jobs:
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }} APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
APPLE_ID: ${{ secrets.APPLE_ID }} APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
WINDOWS_SIGN_EXECUTABLE: ${{ vars.WINDOWS_SIGN_EXECUTABLE }}
- name: Publish release - name: Publish release
uses: softprops/action-gh-release@v2 uses: softprops/action-gh-release@v2

10
bin/electron-forge/sign-windows.cjs
View File

@ -1,8 +1,14 @@
const child_process = require("child_process"); const child_process = require("child_process");
const SIGN_EXECUTABLE = "C:\\ev_signer_trilium\\ev_signer_trilium.exe";
module.exports = function (filePath) { module.exports = function (filePath) {
const command = `${SIGN_EXECUTABLE} --executable "${filePath}"`; const { WINDOWS_SIGN_EXECUTABLE } = process.env;
if (!WINDOWS_SIGN_EXECUTABLE) {
console.warn("[Sign] Skip signing due to missing environment variable.");
return;
}
const command = `${WINDOWS_SIGN_EXECUTABLE} --executable "${filePath}"`;
console.log(`[Sign] ${command}`); console.log(`[Sign] ${command}`);
child_process.execSync(command); child_process.execSync(command);
} }