Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-07-27 18:12:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(code): stop loading unnecessary extensions for read-only mode

Browse Source
This commit is contained in:
Elian Doran 2025-05-11 18:51:44 +03:00
parent a20a51fa75
commit 2704548eb8
No known key found for this signature in database
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/codemirror/src/index.ts
View File

@ -37,7 +37,6 @@ export default class CodeMirror extends EditorView {
extensions = [ extensions = [
...extensions, ...extensions,
languageCompartment.of([]), languageCompartment.of([]),
historyCompartment.of(history()),
syntaxHighlighting(defaultHighlightStyle, { fallback: true }), syntaxHighlighting(defaultHighlightStyle, { fallback: true }),
highlightActiveLine(), highlightActiveLine(),
highlightSelectionMatches(), highlightSelectionMatches(),
@ -52,22 +51,26 @@ export default class CodeMirror extends EditorView {
]) ])
] ]
if (config.readOnly) { if (!config.readOnly) {
extensions.push(EditorState.readOnly.of(true)); // Logic specific to editable notes
} if (config.placeholder) {
extensions.push(placeholder(config.placeholder));
}
if (config.placeholder) { if (config.onContentChanged) {
extensions.push(placeholder(config.placeholder)); extensions.push(EditorView.updateListener.of((v) => this.#onDocumentUpdated(v)));
}
extensions.push(historyCompartment.of(history()));
} else {
// Logic specific to read-only notes
extensions.push(EditorState.readOnly.of(true));
} }
if (config.lineWrapping) { if (config.lineWrapping) {
extensions.push(EditorView.lineWrapping); extensions.push(EditorView.lineWrapping);
} }
if (config.onContentChanged) {
extensions.push(EditorView.updateListener.of((v) => this.#onDocumentUpdated(v)));
}
super({ super({
parent: config.parent, parent: config.parent,
extensions extensions
@ -101,6 +104,10 @@ export default class CodeMirror extends EditorView {
* Clears the history of undo/redo. Generally useful when changing to a new document. * Clears the history of undo/redo. Generally useful when changing to a new document.
*/ */
clearHistory() { clearHistory() {
if (this.config.readOnly) {
return;
}
this.dispatch({ this.dispatch({
effects: [ this.historyCompartment.reconfigure([]) ] effects: [ this.historyCompartment.reconfigure([]) ]
}); });