Tools/Notes
1
0
Fork 0
mirror of https://github.com/TriliumNext/Notes.git synced 2025-08-19 09:02:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(canvas): significant lag when dragging (fixes #967)

Browse Source
This commit is contained in:
Elian Doran 2025-01-18 00:14:31 +02:00
parent 7cf1fbf088
commit 2167948509
No known key found for this signature in database
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/public/app/services/spaced_update.ts
View File

@ -43,6 +43,14 @@ export default class SpacedUpdate {
return allSaved; return allSaved;
} }
/**
* Normally {@link scheduleUpdate()} would actually trigger the update only once per {@link updateInterval}. If the method is called 200 times within 20s, it will execute only 20 times.
* Sometimes, if the updates are continuous this would cause a performance impact. Resetting the time ensures that the calls to {@link triggerUpdate} have stopped before actually triggering an update.
*/
resetUpdateTimer() {
this.lastUpdated = Date.now();
}
triggerUpdate() { triggerUpdate() {
if (!this.changed) { if (!this.changed) {
return; return;

15
src/public/app/widgets/type_widgets/canvas.js
View File

@ -9,7 +9,7 @@ const TPL = `
.excalidraw .App-menu_top .buttonList { .excalidraw .App-menu_top .buttonList {
display: flex; display: flex;
} }
/* Conflict between excalidraw and bootstrap classes keeps the menu hidden */ /* Conflict between excalidraw and bootstrap classes keeps the menu hidden */
/* https://github.com/zadam/trilium/issues/3780 */ /* https://github.com/zadam/trilium/issues/3780 */
/* https://github.com/excalidraw/excalidraw/issues/6567 */ /* https://github.com/excalidraw/excalidraw/issues/6567 */
@ -20,7 +20,7 @@ const TPL = `
.excalidraw-wrapper { .excalidraw-wrapper {
height: 100%; height: 100%;
} }
.excalidraw button[data-testid="json-export-button"] { .excalidraw button[data-testid="json-export-button"] {
display: none !important; display: none !important;
} }
@ -31,23 +31,23 @@ const TPL = `
.zen-mode-transition.App-menu_bottom--transition-left { .zen-mode-transition.App-menu_bottom--transition-left {
transform: none; transform: none;
} }
/* collaboration not possible so hide the button */ /* collaboration not possible so hide the button */
.CollabButton { .CollabButton {
display: none !important; display: none !important;
} }
button[data-testid='save-button'], button[data-testid='json-export-button'] { button[data-testid='save-button'], button[data-testid='json-export-button'] {
display: none !important; /* these exports don't work, user should use import/export dialog */ display: none !important; /* these exports don't work, user should use import/export dialog */
} }
.library-button { .library-button {
display: none !important; /* library won't work without extra support which isn't currently implemented */ display: none !important; /* library won't work without extra support which isn't currently implemented */
} }
</style> </style>
<!-- height here necessary. otherwise excalidraw not shown --> <!-- height here necessary. otherwise excalidraw not shown -->
<div class="canvas-render" style="height: 100%"></div> <div class="canvas-render" style="height: 100%"></div>
</div> </div>
`; `;
@ -383,9 +383,10 @@ export default class ExcalidrawTypeWidget extends TypeWidget {
/** /**
* save content to backend * save content to backend
* spacedUpdate is kind of a debouncer.
*/ */
saveData() { saveData() {
// Since Excalidraw sends an enormous amount of events, wait for them to stop before actually saving.
this.spacedUpdate.resetUpdateTimer();
this.spacedUpdate.scheduleUpdate(); this.spacedUpdate.scheduleUpdate();
} }