diff --git a/Dockerfile b/Dockerfile index 5173b60f3..fa3a73880 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,7 +1,7 @@ -# !!! Don't try to build this Dockerfile directly, run it through bin/build-docker.sh script !!! -FROM node:20.15.1-bullseye-slim +# Build stage +FROM node:20.15.1-bullseye-slim AS builder -# Configure system dependencies +# Configure build dependencies in a single layer RUN apt-get update && apt-get install -y --no-install-recommends \ autoconf \ automake \ @@ -12,49 +12,52 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ nasm \ libpng-dev \ python3 \ - gosu \ && rm -rf /var/lib/apt/lists/* -# Create app directory WORKDIR /usr/src/app -# Bundle app source +# Copy only necessary files for build COPY . . COPY server-package.json package.json -# Copy TypeScript build artifacts into the original directory structure. -# Copy the healthcheck +# Build and cleanup in a single layer RUN cp -R build/src/* src/. && \ cp build/docker_healthcheck.js . && \ rm -r build && \ - rm docker_healthcheck.ts - -# Install app dependencies -RUN apt-get purge -y --auto-remove \ - autoconf \ - automake \ - g++ \ - gcc \ - libtool \ - make \ - nasm \ - libpng-dev \ - python3 \ - && rm -rf /var/lib/apt/lists/* -RUN npm install && \ + rm docker_healthcheck.ts && \ + npm install && \ npm run webpack && \ - npm prune --omit=dev -RUN cp src/public/app/share.js src/public/app-dist/. && \ + npm prune --omit=dev && \ + npm cache clean --force && \ + cp src/public/app/share.js src/public/app-dist/. && \ cp -r src/public/app/doc_notes src/public/app-dist/. && \ - rm -rf src/public/app && rm src/services/asset_path.ts + rm -rf src/public/app && \ + rm src/services/asset_path.ts -# Some setup tools need to be kept +# Runtime stage +FROM node:20.15.1-bullseye-slim + +# Install only runtime dependencies RUN apt-get update && apt-get install -y --no-install-recommends \ gosu \ - && rm -rf /var/lib/apt/lists/* + && rm -rf /var/lib/apt/lists/* && \ + rm -rf /var/cache/apt/* -# Start the application +WORKDIR /usr/src/app + +# Copy only necessary files from builder +COPY --from=builder /usr/src/app/node_modules ./node_modules +COPY --from=builder /usr/src/app/src ./src +COPY --from=builder /usr/src/app/db ./db +COPY --from=builder /usr/src/app/docker_healthcheck.js . +COPY --from=builder /usr/src/app/start-docker.sh . +COPY --from=builder /usr/src/app/package.json . +COPY --from=builder /usr/src/app/config-sample.ini . +COPY --from=builder /usr/src/app/images ./images +COPY --from=builder /usr/src/app/translations ./translations +COPY --from=builder /usr/src/app/libraries ./libraries + +# Configure container EXPOSE 8080 CMD [ "./start-docker.sh" ] - HEALTHCHECK --start-period=10s CMD exec gosu node node docker_healthcheck.js \ No newline at end of file diff --git a/Dockerfile.alpine b/Dockerfile.alpine index 7ace8e964..e4b7f4a7d 100644 --- a/Dockerfile.alpine +++ b/Dockerfile.alpine @@ -1,7 +1,7 @@ -# !!! Don't try to build this Dockerfile directly, run it through bin/build-docker.sh script !!! -FROM node:20.15.1-alpine +# Build stage +FROM node:20.15.1-alpine AS builder -# Configure system dependencies +# Configure build dependencies RUN apk add --no-cache --virtual .build-dependencies \ autoconf \ automake \ @@ -11,43 +11,52 @@ RUN apk add --no-cache --virtual .build-dependencies \ make \ nasm \ libpng-dev \ - python3 + python3 -# Create app directory WORKDIR /usr/src/app -# Bundle app source +# Copy only necessary files for build COPY . . - COPY server-package.json package.json -# Copy TypeScript build artifacts into the original directory structure. -# Copy the healthcheck +# Build and cleanup in a single layer RUN cp -R build/src/* src/. && \ cp build/docker_healthcheck.js . && \ rm -r build && \ - rm docker_healthcheck.ts - -# Install app dependencies -RUN set -x && \ + rm docker_healthcheck.ts && \ npm install && \ - apk del .build-dependencies && \ npm run webpack && \ npm prune --omit=dev && \ + npm cache clean --force && \ cp src/public/app/share.js src/public/app-dist/. && \ cp -r src/public/app/doc_notes src/public/app-dist/. && \ rm -rf src/public/app && \ rm src/services/asset_path.ts +# Runtime stage +FROM node:20.15.1-alpine -# Some setup tools need to be kept +# Install runtime dependencies RUN apk add --no-cache su-exec shadow -# Add application user and setup proper volume permissions +WORKDIR /usr/src/app + +# Copy only necessary files from builder +COPY --from=builder /usr/src/app/node_modules ./node_modules +COPY --from=builder /usr/src/app/src ./src +COPY --from=builder /usr/src/app/db ./db +COPY --from=builder /usr/src/app/docker_healthcheck.js . +COPY --from=builder /usr/src/app/start-docker.sh . +COPY --from=builder /usr/src/app/package.json . +COPY --from=builder /usr/src/app/config-sample.ini . +COPY --from=builder /usr/src/app/images ./images +COPY --from=builder /usr/src/app/translations ./translations +COPY --from=builder /usr/src/app/libraries ./libraries + +# Add application user RUN adduser -s /bin/false node; exit 0 -# Start the application +# Configure container EXPOSE 8080 CMD [ "./start-docker.sh" ] - -HEALTHCHECK --start-period=10s CMD exec su-exec node node docker_healthcheck.js +HEALTHCHECK --start-period=10s CMD exec su-exec node node docker_healthcheck.js \ No newline at end of file