From 15faf161b53b80facb8ddc82e1b8e044d7249007 Mon Sep 17 00:00:00 2001 From: Panagiotis Papadopoulos Date: Tue, 7 Jan 2025 08:37:37 +0100 Subject: [PATCH] refactor(views/login): simplify userAgent matching MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - there is no need to have the Regexp check done in 2 separate tests – just do it once - I also have ordered the userAgents by order of "popularity", so (in theory) it should match faster for most people this way (although realistically you will not notice this at all) --- src/views/login.ejs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/views/login.ejs b/src/views/login.ejs index 8142b1c1c..af4152df5 100644 --- a/src/views/login.ejs +++ b/src/views/login.ejs @@ -66,9 +66,8 @@ if (mQ?.media === '(pointer:coarse)') return !!mQ.matches; if ('orientation' in window) return true; - - return /\b(BlackBerry|webOS|iPhone|IEMobile)\b/i.test(navigator.userAgent) || - /\b(Android|Windows Phone|iPad|iPod)\b/i.test(navigator.userAgent); + const userAgentsRegEx = /\b(Android|iPhone|iPad|iPod|Windows Phone|BlackBerry|webOS|IEMobile)\b/i + return userAgentsRegEx.test(navigator.userAgent) }