From 0ac397e7ffbca5f2821b75b719ca04581ada388b Mon Sep 17 00:00:00 2001 From: zadam Date: Mon, 11 Dec 2023 23:05:05 +0100 Subject: [PATCH] fix setNoteToParent API breakage, closes #4505 --- src/services/tree.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/services/tree.js b/src/services/tree.js index 60f481d55..66276ab2f 100644 --- a/src/services/tree.js +++ b/src/services/tree.js @@ -209,8 +209,9 @@ function sortNotesIfNeeded(parentNoteId) { function setNoteToParent(noteId, prefix, parentNoteId) { const parentNote = becca.getNote(parentNoteId); - if (!parentNote) { - throw new Error(`Cannot move note to deleted parent note '${parentNoteId}'`); + if (parentNoteId && !parentNote) { + // null parentNoteId is a valid value + throw new Error(`Cannot move note to deleted / missing parent note '${parentNoteId}'`); } // case where there might be more such branches is ignored. It's expected there should be just one