From 04bd5415423934dbf37505f86de41389f6d83fef Mon Sep 17 00:00:00 2001
From: SiriusXT <1160925501@qq.com>
Date: Wed, 21 May 2025 17:15:54 +0800
Subject: [PATCH] fix(markdown): Make the math formula conversion ignore
 formulas inside code blocks

---
 .../src/services/import/markdown.spec.ts      | 12 ++-
 apps/server/src/services/import/markdown.ts   | 75 ++++++++++++-------
 2 files changed, 59 insertions(+), 28 deletions(-)

diff --git a/apps/server/src/services/import/markdown.spec.ts b/apps/server/src/services/import/markdown.spec.ts
index fc38cdca0..8768d3252 100644
--- a/apps/server/src/services/import/markdown.spec.ts
+++ b/apps/server/src/services/import/markdown.spec.ts
@@ -206,6 +206,16 @@ $$`;
         expect(markdownService.renderToHtml(input, "Title")).toStrictEqual(expected);
     });
 
+    it("ignores math formulas inside code blocks and converts inline math expressions correctly", () => {
+        const result = markdownService.renderToHtml(trimIndentation`\
+            \`\`\`unknownlanguage
+            $$a+b$$
+            \`\`\`
+        `, "title");
+        expect(result).toBe(trimIndentation`\
+            <pre><code class="language-text-x-trilium-auto">$$a+b$$</code></pre>`);
+    });
+
     it("converts specific inline math expression into Mathtex format", () => {
         const input = `This is a formula: $\\mathcal{L}_{task} + \\mathcal{L}_{od}$ inside a sentence.`;
         const expected = /*html*/`<p>This is a formula: <span class="math-tex">\\(\\mathcal{L}_{task} + \\mathcal{L}_{od}\\)</span> inside a sentence.</p>`;
@@ -264,7 +274,7 @@ $$`;
     });
 
     it("imports todo lists properly", () => {
-         const input = trimIndentation`\
+        const input = trimIndentation`\
             - [x] Hello
             - [ ] World`;
         const expected = `<ul class="todo-list"><li><label class="todo-list__label"><input type="checkbox" checked="checked" disabled="disabled"><span class="todo-list__label__description">Hello</span></label></li><li><label class="todo-list__label"><input type="checkbox" disabled="disabled"><span class="todo-list__label__description">World</span></label></li></ul>`;
diff --git a/apps/server/src/services/import/markdown.ts b/apps/server/src/services/import/markdown.ts
index e49f5eaa4..e9ad6c4ae 100644
--- a/apps/server/src/services/import/markdown.ts
+++ b/apps/server/src/services/import/markdown.ts
@@ -120,9 +120,9 @@ class CustomMarkdownRenderer extends Renderer {
 function renderToHtml(content: string, title: string) {
     // Double-escape slashes in math expression because they are otherwise consumed by the parser somewhere.
     content = content.replaceAll("\\$", "\\\\$");
-    
+
     // Extract formulas and replace them with placeholders to prevent interference from Markdown rendering
-    const { processedText, formulaMap } = extractFormulas(content);
+    const { processedText, placeholderMap: formulaMap } = extractFormulas(content);
 
     let html = parse(processedText, {
         async: false,
@@ -130,7 +130,7 @@ function renderToHtml(content: string, title: string) {
     }) as string;
 
     // After rendering, replace placeholders back with the formula HTML
-    html = restoreFormulas(html, formulaMap);
+    html = restoreFromMap(html, formulaMap);
 
     // h1 handling needs to come before sanitization
     html = importUtils.handleH1(html, title);
@@ -159,36 +159,57 @@ function getNormalizedMimeFromMarkdownLanguage(language: string | undefined) {
     return MIME_TYPE_AUTO;
 }
 
-function extractFormulas(text: string): { processedText: string, formulaMap: Map<string, string> } {
-    const formulaMap = new Map<string, string>();
-    let formulaId = 0;
+function extractCodeBlocks(text: string): { processedText: string, placeholderMap: Map<string, string> } {
+    const codeMap = new Map<string, string>();
+    let id = 0;
+    const timestamp = Date.now();
 
-    // Display math
-    text = text.replace(/(?<!\\)\$\$(.+?)\$\$/gs, (_, formula) => {
-        const key = `<!--FORMULA_BLOCK_${formulaId++}-->`;
-        formulaMap.set(key, `$$${formula}$$`);
+    // Multi-line code block and Inline code
+    text = text.replace(/```[\s\S]*?```/g, (m) => {
+        const key = `<!--CODE_BLOCK_${timestamp}_${id++}-->`;
+        codeMap.set(key, m);
+        return key;
+    }).replace(/`[^`\n]+`/g, (m) => {
+        const key = `<!--INLINE_CODE_${timestamp}_${id++}-->`;
+        codeMap.set(key, m);
         return key;
     });
 
-    // Inline math
-    text = text.replace(/(?<!\\)\$(.+?)\$/g, (_, formula) => {
-        const key = `<!--FORMULA_INLINE_${formulaId++}-->`;
-        formulaMap.set(key, `$${formula}$`);
-        return key;
-    });
-    return { processedText: text, formulaMap };
+    return { processedText: text, placeholderMap: codeMap };
 }
 
-function restoreFormulas(html: string, formulaMap: Map<string, string>): string {
-    for (const [key, formula] of formulaMap.entries()) {
-        const isBlock = formula.startsWith("$$");
-        const inner = formula.replace(/^\${1,2}|\${1,2}$/g, "");
-        const rendered = isBlock
-            ? `<span class="math-tex">\\[${inner}\\]</span>`
-            : `<span class="math-tex">\\(${inner}\\)</span>`;
-        html = html.replaceAll(key, rendered);
-    }
-    return html;
+function extractFormulas(text: string): { processedText: string, placeholderMap: Map<string, string> } {
+    // Protect the $ signs inside code blocks from being recognized as formulas.
+    const { processedText: noCodeText, placeholderMap: codeMap } = extractCodeBlocks(text);
+
+    const formulaMap = new Map<string, string>();
+    let id = 0;
+    const timestamp = Date.now();
+
+    // Display math and Inline math
+    let processedText = noCodeText.replace(/(?<!\\)\$\$((?:(?!\n{2,})[\s\S])+?)\$\$/g, (_, formula) => {
+        const key = `<!--FORMULA_BLOCK_${timestamp}_${id++}-->`;
+        const rendered = `<span class="math-tex">\\[${formula}\\]</span>`;
+        formulaMap.set(key, rendered);
+        return key;
+    }).replace(/(?<!\\)\$(.+?)\$/g, (_, formula) => {
+        const key = `<!--FORMULA_INLINE_${timestamp}_${id++}-->`;
+        const rendered = `<span class="math-tex">\\(${formula}\\)</span>`;
+        formulaMap.set(key, rendered);
+        return key;
+    });
+
+    processedText = restoreFromMap(processedText, codeMap);
+
+    return { processedText, placeholderMap: formulaMap };
+}
+
+function restoreFromMap(text: string, map: Map<string, string>): string {
+    if (map.size === 0) return text;
+    const pattern = [...map.keys()]
+        .map(k => k.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'))
+        .join('|');
+    return text.replace(new RegExp(pattern, 'g'), match => map.get(match) ?? match);
 }
 
 const renderer = new CustomMarkdownRenderer({ async: false });