MCP/playwright-mcp
1
0
Fork 0
mirror of https://github.com/microsoft/playwright-mcp.git synced 2025-07-26 08:32:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: browser_take_screenshot to not require snapshot unless element is specified (#725)

Browse Source
This commit is contained in:
Copilot 2025-07-21 10:52:06 -07:00 committed by GitHub
parent efe3ff0c7c
commit eeeab4f042
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tools/screenshot.ts
View File

@ -53,7 +53,6 @@ const screenshot = defineTool({
handle: async (context, params) => { handle: async (context, params) => {
const tab = context.currentTabOrDie(); const tab = context.currentTabOrDie();
const snapshot = tab.snapshotOrDie();
const fileType = params.raw ? 'png' : 'jpeg'; const fileType = params.raw ? 'png' : 'jpeg';
const fileName = await outputFile(context.config, params.filename ?? `page-${new Date().toISOString()}.${fileType}`); const fileName = await outputFile(context.config, params.filename ?? `page-${new Date().toISOString()}.${fileType}`);
const options: playwright.PageScreenshotOptions = { const options: playwright.PageScreenshotOptions = {
@ -70,7 +69,8 @@ const screenshot = defineTool({
`// Screenshot ${screenshotTarget} and save it as ${fileName}`, `// Screenshot ${screenshotTarget} and save it as ${fileName}`,
]; ];
const locator = params.ref ? snapshot.refLocator({ element: params.element || '', ref: params.ref }) : null; // Only get snapshot when element screenshot is needed
const locator = params.ref ? tab.snapshotOrDie().refLocator({ element: params.element || '', ref: params.ref }) : null;
if (locator) if (locator)
code.push(`await page.${await generateLocator(locator)}.screenshot(${javascript.formatObject(options)});`); code.push(`await page.${await generateLocator(locator)}.screenshot(${javascript.formatObject(options)});`);

28
tests/screenshot.spec.ts
View File

@ -250,3 +250,31 @@ test('browser_take_screenshot (fullPage with element should error)', async ({ st
expect(result.isError).toBe(true); expect(result.isError).toBe(true);
expect(result.content?.[0]?.text).toContain('fullPage cannot be used with element screenshots'); expect(result.content?.[0]?.text).toContain('fullPage cannot be used with element screenshots');
}); });
test('browser_take_screenshot (viewport without snapshot)', async ({ startClient, server }, testInfo) => {
const { client } = await startClient({
config: { outputDir: testInfo.outputPath('output') },
});
// Ensure we have a tab but don't navigate anywhere (no snapshot captured)
expect(await client.callTool({
name: 'browser_tab_list',
})).toContainTextContent('about:blank');
// This should work without requiring a snapshot since it's a viewport screenshot
expect(await client.callTool({
name: 'browser_take_screenshot',
})).toEqual({
content: [
{
data: expect.any(String),
mimeType: 'image/jpeg',
type: 'image',
},
{
text: expect.stringContaining(`Screenshot viewport and save it as`),
type: 'text',
},
],
});
});