From ee33097abe8358402d39366249002383096a1a6e Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Tue, 13 May 2025 16:17:45 -0700
Subject: [PATCH] chore: normalize --no- options (#413)

---
 src/config.ts     | 17 +++++++++++++----
 tests/fixtures.ts |  2 ++
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/config.ts b/src/config.ts
index 27d522a..977c6b5 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -38,8 +38,8 @@ export type CLIOptions = {
   host?: string;
   ignoreHttpsErrors?: boolean;
   isolated?: boolean;
-  noImageResponses?: boolean;
-  sandbox?: boolean;
+  imageResponses: boolean;
+  sandbox: boolean;
   outputDir?: string;
   port?: number;
   proxyBypass?: string;
@@ -111,8 +111,10 @@ export async function configFromCLIOptions(cliOptions: CLIOptions): Promise<Conf
 
   if (browserName === 'chromium') {
     (launchOptions as any).cdpPort = await findFreePort();
-    if (cliOptions.sandbox === false)
+    if (!cliOptions.sandbox) {
+      // --no-sandbox was passed, disable the sandbox
       launchOptions.chromiumSandbox = false;
+    }
   }
 
   if (cliOptions.proxyServer) {
@@ -148,7 +150,7 @@ export async function configFromCLIOptions(cliOptions: CLIOptions): Promise<Conf
   if (cliOptions.blockServiceWorkers)
     contextOptions.serviceWorkers = 'block';
 
-  return {
+  const result: Config = {
     browser: {
       browserName,
       isolated: cliOptions.isolated,
@@ -169,6 +171,13 @@ export async function configFromCLIOptions(cliOptions: CLIOptions): Promise<Conf
     },
     outputDir: cliOptions.outputDir,
   };
+
+  if (!cliOptions.imageResponses) {
+    // --no-image-responses was passed, disable image responses
+    result.noImageResponses = true;
+  }
+
+  return result;
 }
 
 async function findFreePort() {
diff --git a/tests/fixtures.ts b/tests/fixtures.ts
index da311e9..0779097 100644
--- a/tests/fixtures.ts
+++ b/tests/fixtures.ts
@@ -65,6 +65,8 @@ export const test = baseTest.extend<TestFixtures & TestOptions, WorkerFixtures>(
 
     await use(async options => {
       const args = ['--user-data-dir', path.relative(configDir, userDataDir)];
+      if (process.env.CI && process.platform === 'linux')
+        args.push('--no-sandbox');
       if (mcpHeadless)
         args.push('--headless');
       if (mcpBrowser)