chore: normalize --no- options (#413)

This commit is contained in:
Pavel Feldman 2025-05-13 16:17:45 -07:00 committed by GitHub
parent ab20175826
commit ee33097abe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 4 deletions

View File

@ -38,8 +38,8 @@ export type CLIOptions = {
host?: string;
ignoreHttpsErrors?: boolean;
isolated?: boolean;
noImageResponses?: boolean;
sandbox?: boolean;
imageResponses: boolean;
sandbox: boolean;
outputDir?: string;
port?: number;
proxyBypass?: string;
@ -111,8 +111,10 @@ export async function configFromCLIOptions(cliOptions: CLIOptions): Promise<Conf
if (browserName === 'chromium') {
(launchOptions as any).cdpPort = await findFreePort();
if (cliOptions.sandbox === false)
if (!cliOptions.sandbox) {
// --no-sandbox was passed, disable the sandbox
launchOptions.chromiumSandbox = false;
}
}
if (cliOptions.proxyServer) {
@ -148,7 +150,7 @@ export async function configFromCLIOptions(cliOptions: CLIOptions): Promise<Conf
if (cliOptions.blockServiceWorkers)
contextOptions.serviceWorkers = 'block';
return {
const result: Config = {
browser: {
browserName,
isolated: cliOptions.isolated,
@ -169,6 +171,13 @@ export async function configFromCLIOptions(cliOptions: CLIOptions): Promise<Conf
},
outputDir: cliOptions.outputDir,
};
if (!cliOptions.imageResponses) {
// --no-image-responses was passed, disable image responses
result.noImageResponses = true;
}
return result;
}
async function findFreePort() {

View File

@ -65,6 +65,8 @@ export const test = baseTest.extend<TestFixtures & TestOptions, WorkerFixtures>(
await use(async options => {
const args = ['--user-data-dir', path.relative(configDir, userDataDir)];
if (process.env.CI && process.platform === 'linux')
args.push('--no-sandbox');
if (mcpHeadless)
args.push('--headless');
if (mcpBrowser)