MCP/playwright-mcp
1
0
Fork 0
mirror of https://github.com/microsoft/playwright-mcp.git synced 2025-07-27 00:52:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: rename console to consoleMessages (#372)

Browse Source 
Motivation: `console` is a global object in Node.js and having a method
like that confuses intellisense.
This commit is contained in:
Max Schmitt 2025-05-07 16:40:08 +02:00 committed by GitHub
parent b5be37e5e7
commit a115c31953
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/tab.ts
View File

@ -23,7 +23,7 @@ import type { Context } from './context.js';
export class Tab { export class Tab {
readonly context: Context; readonly context: Context;
readonly page: playwright.Page; readonly page: playwright.Page;
private _console: playwright.ConsoleMessage[] = []; private _consoleMessages: playwright.ConsoleMessage[] = [];
private _requests: Map<playwright.Request, playwright.Response | null> = new Map(); private _requests: Map<playwright.Request, playwright.Response | null> = new Map();
private _snapshot: PageSnapshot | undefined; private _snapshot: PageSnapshot | undefined;
private _onPageClose: (tab: Tab) => void; private _onPageClose: (tab: Tab) => void;
@ -32,7 +32,7 @@ export class Tab {
this.context = context; this.context = context;
this.page = page; this.page = page;
this._onPageClose = onPageClose; this._onPageClose = onPageClose;
page.on('console', event => this._console.push(event)); page.on('console', event => this._consoleMessages.push(event));
page.on('request', request => this._requests.set(request, null)); page.on('request', request => this._requests.set(request, null));
page.on('response', response => this._requests.set(response.request(), response)); page.on('response', response => this._requests.set(response.request(), response));
page.on('framenavigated', frame => { page.on('framenavigated', frame => {
@ -56,7 +56,7 @@ export class Tab {
} }
private _clearCollectedArtifacts() { private _clearCollectedArtifacts() {
this._console.length = 0; this._consoleMessages.length = 0;
this._requests.clear(); this._requests.clear();
} }
@ -100,8 +100,8 @@ export class Tab {
return this._snapshot; return this._snapshot;
} }
console(): playwright.ConsoleMessage[] { consoleMessages(): playwright.ConsoleMessage[] {
return this._console; return this._consoleMessages;
} }
requests(): Map<playwright.Request, playwright.Response | null> { requests(): Map<playwright.Request, playwright.Response | null> {

2
src/tools/console.ts
View File

@ -27,7 +27,7 @@ const console = defineTool({
type: 'readOnly', type: 'readOnly',
}, },
handle: async context => { handle: async context => {
const messages = context.currentTabOrDie().console(); const messages = context.currentTabOrDie().consoleMessages();
const log = messages.map(message => `[${message.type().toUpperCase()}] ${message.text()}`).join('\n'); const log = messages.map(message => `[${message.type().toUpperCase()}] ${message.text()}`).join('\n');
return { return {
code: [`// <internal code to get console messages>`], code: [`// <internal code to get console messages>`],