From 269d8d8a4d8c01772fa1a06a39c27760ebfe5168 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 18 Jul 2025 19:52:18 +0000 Subject: [PATCH] Add conditional webkit expectations for browser_evaluate error test Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com> --- tests/evaluate.spec.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/evaluate.spec.ts b/tests/evaluate.spec.ts index 36a929a..e25f9e6 100644 --- a/tests/evaluate.spec.ts +++ b/tests/evaluate.spec.ts @@ -50,7 +50,7 @@ test('browser_evaluate (element)', async ({ client, server }) => { })).toContainTextContent(`- Result: "red"`); }); -test('browser_evaluate (error)', async ({ client, server }) => { +test('browser_evaluate (error)', async ({ client, server, mcpBrowser }) => { expect(await client.callTool({ name: 'browser_navigate', arguments: { url: server.HELLO_WORLD }, @@ -68,6 +68,12 @@ test('browser_evaluate (error)', async ({ client, server }) => { expect(result.isError).toBe(true); // Check that JavaScript error details are contained in the response - expect(result.content?.[0].text).toContain('page._evaluateFunction'); - expect(result.content?.[0].text).toContain('undefinedVariable is not defined'); + if (mcpBrowser === 'webkit') { + // Webkit has different error message format + expect(result.content?.[0].text).toContain('undefinedVariable is not defined'); + } else { + // Chrome, Firefox, etc. include the Playwright evaluation context + expect(result.content?.[0].text).toContain('page._evaluateFunction'); + expect(result.content?.[0].text).toContain('undefinedVariable is not defined'); + } });